23392 Commits

Author SHA1 Message Date
81003f2d08 Ignore ERROR_SHARING_VIOLATION error on windows
When removing the gvproxy pid file, under CI conditions we could hit a
case where the PID file being removed seemed to have an open handle on
it still.  I could not find anything in podman that left an open handle
and gvproxy would have quit before this, so we think it is likely
another process holding it.  I could not find root cause with CI because
I could not trip the flake.

this new code allows windows (specifically hyperv bc WSL does not use
GVProxy) to ignore an ERROR_SHARING_VIOLATION.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2024-08-06 14:09:36 -05:00
f9b67cea57 CI: manifest system tests: make parallel-safe
Use safename instead of hardcoded "test"

Start registry once, in setup_file(), instead of requiring
individual tests to do so.

Add explicit --authfile arg to a bunch of places that now need it

Minor cleanup and improvements in test descriptions. I may have
gotten a little carried away here, but if this test ever fails
these additions will make someone's life much easier.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-06 13:07:10 -06:00
eb7ce80cf9 Create volume path before state initialization
Strictly speaking we don't need the path yet, but it existing
prevents a lot of strangeness in our path-checking logic to
validate the current Podman configuration, as it was the only
path that might not exist this early in init.

Fixes #23515

Signed-off-by: Matt Heon <mheon@redhat.com>
2024-08-06 13:42:09 -04:00
84a5119d17 vendor: update c/storage
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-08-06 17:51:14 +02:00
128fde1734 Merge pull request #23518 from Luap99/test-new-vms
Update CI images
2024-08-06 13:44:58 +00:00
029f9b38cc CI: fix broken libkrun test
Same issues as in the volume ops test, the libkrun volume is not working
properly (#23296).

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-06 14:45:52 +02:00
3275fd2dda Merge pull request #23512 from rhatdan/mount
Remove another race condition when mounting containers or images
2024-08-06 11:41:10 +00:00
69862b7251 Merge pull request #23460 from Luap99/cleanup-term
libpod: inhibit SIGTERM during cleanup()
2024-08-06 11:38:27 +00:00
1912dd4bf6 test/e2e: work around for pasta issue
Use network slirp4netns for the registry container to work around a
pasta regression (#23517). This should be revert once it is fixed in
pasta and included in our CI images.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-06 13:16:34 +02:00
71bcd25ab6 test/e2e: fix missing exit code checks
Both push commands didn't check the exit code so make sure they actually
work.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-06 13:16:34 +02:00
082650b68f Test new CI images
Source: https://github.com/containers/automation_images/pull/371

Signed-off-by: Ed Santiago <santiago@redhat.com>
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-06 13:15:53 +02:00
abd586cb1c Remove another race condition when mounting containers or images
Fixes: https://github.com/containers/podman/issues/23507

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-08-06 06:23:13 -04:00
b1d111c770 Merge pull request #23391 from l0rd/build-contexts
Convert additional build context paths on Windows
2024-08-06 10:18:41 +00:00
7e469996b1 Merge pull request #23513 from containers/renovate/common-image-and-storage-deps
fix(deps): update github.com/containers/common digest to c0cc6b7
2024-08-06 08:31:27 +00:00
91b3fdbba3 fix(deps): update github.com/containers/common digest to c0cc6b7
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-06 00:10:39 +00:00
7c38ee7565 Merge pull request #23509 from l0rd/fix-23502
Change Windows installer MajorUpgrade Schedule
2024-08-06 00:08:10 +00:00
01d739a65e Change Windows installer MajorUpgrade Schedule
Use Schedule "afterInstallExecute" (instead of the
default "afterInstallValidate") in the Windows
installer MajorUpgrade element. That avoid
overriding eventual users changes to the podman
machine configuration file created by the
installer.

Fixes #23502

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-08-05 21:52:58 +02:00
0bd43f4e12 Merge pull request #23461 from edsantiago/ci-machine-nocache
CI: podman-machine: do not use cache registry
2024-08-05 15:49:24 +00:00
5ca337d2e8 Merge pull request #23494 from rhatdan/VENDOR
Remove runc edit to lock to specific version
2024-08-05 14:34:38 +00:00
63ec8293ee Merge pull request #23493 from rhatdan/buildah
Ignore missing containers when calling GetExternalContainerLists
2024-08-05 13:08:40 +00:00
9742b4ad6f Merge pull request #23500 from containers/renovate/golang.org-x-sys-0.x
fix(deps): update module golang.org/x/sys to v0.23.0
2024-08-05 12:43:53 +00:00
d628e14355 Ignore missing containers when calling GetExternalContainerLists
Race condition between listing containers and figuring out if it
is a buildah container.

Fixe: https://github.com/containers/podman/issues/23492

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-08-05 08:18:57 -04:00
37226e2e93 Remove runc edit to lock to specific version
Fixes: https://github.com/containers/podman/issues/19795

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-08-05 08:08:04 -04:00
43a077db87 Merge pull request #23484 from edsantiago/safename-600
CI: completion system test: use safename
2024-08-05 11:56:06 +00:00
67ce828152 fix(deps): update module golang.org/x/sys to v0.23.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-05 11:26:07 +00:00
87dad1caef CI: podman-machine: do not use cache registry
It's too difficult to keep the podman-machine image up-to-date.
And, we can't use the cache on Mac/Windows, so if quay is down
we're hosed no matter what.

Add a "nocache" mechanism to install_test_configs() and use that
in machine test setup.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-05 05:12:36 -06:00
bfb42b3b15 CI: completion system test: use safename
Ongoing efforts to make system tests parallel-safe

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-05 05:09:19 -06:00
44604e9941 Merge pull request #23501 from l0rd/disable-win-installer-test
Temporarily disable failing Windows Installer CI test
2024-08-05 11:06:33 +00:00
e429160e5b Temporarly disable failing Windows Installer CI test
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-08-05 11:51:46 +02:00
69a5b28e6e Merge pull request #23455 from lsm5/main-5.3-bump
Version: bump to v5.3.0-dev
2024-08-03 02:20:30 +00:00
0bc073941a Merge pull request #23290 from cevich/add_libkrun_task
Add libkrun Mac task
2024-08-02 09:30:01 +00:00
93338226cb Merge pull request #23476 from giuseppe/idmap-volume-copyup
libpod: fix volume copyup with idmap
2024-08-02 08:43:15 +00:00
3ae1568933 libpod: fix volume copyup with idmap
if idmap is specified for a volume, reverse the mappings when copying
up from the container, so that the original permissions are maintained.

Closes: https://github.com/containers/podman/issues/23467

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-08-01 22:49:27 +02:00
61def05cd9 libpod: avoid hang on errors
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-08-01 22:49:27 +02:00
457c64564a Temp. disable PM basic Volume ops test
Issue 23296

Signed-off-by: Chris Evich <cevich@redhat.com>
2024-08-01 15:01:46 -04:00
029a9aa34e Add libkrun Mac task
Signed-off-by: Chris Evich <cevich@redhat.com>
2024-08-01 15:01:45 -04:00
dfab16e94e Merge pull request #23474 from l0rd/release-workflow-always-checkout
Never skip checkout step in release workflow
2024-08-01 15:04:35 +00:00
014b7af4f3 Never skip checkout step in release workflow
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-08-01 16:09:03 +02:00
bb079937bc Merge pull request #23451 from edsantiago/leak-test-cleanup
System tests: leak_test: readable output
2024-08-01 12:52:34 +00:00
3e43c402ac Merge pull request #23456 from giuseppe/update-c-common-31-7-24
vendor: bump c/common
2024-08-01 12:47:00 +00:00
83e90a2f5b System tests: leak_test: readable output
BATS teardown logs are unreadable, making it almost impossible
to see tiny "Leaked this-or-that" messages.

Solution: new _run_podman_quiet() helper, replaces run_podman
in a small number of cases within teardown. Clunky, and
duplicative, sorry.

New helper for leak_check, basically spits out warnings (and
bumps error count) if it sees any output whatsoever from
individual "podman XXX ls" commands.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-01 05:39:50 -06:00
7c4b1f7aa7 Merge pull request #23431 from edsantiago/clean-up-stray-external
CI: kube test: fix broken external-storage test
2024-08-01 11:30:00 +00:00
803ef5c16f Merge pull request #23384 from edsantiago/root-namespace
CI: enable root user namespaces
2024-08-01 10:32:16 +00:00
5d10f77da5 Merge pull request #23466 from containers/renovate/github.com-docker-go-plugins-helpers-digest
fix(deps): update github.com/docker/go-plugins-helpers digest to 45e2431
2024-08-01 08:56:01 +00:00
f446f59d71 fix(deps): update github.com/docker/go-plugins-helpers digest to 45e2431
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-01 04:17:44 +00:00
75a316aae4 vendor: bump c/common
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-07-31 21:55:28 +02:00
737c08224e Merge pull request #23458 from TomSweeneyRedHat/dev/tsweeney/fixvers
Tweak versions in register_images.go
2024-07-31 14:35:24 -04:00
96eb6377d5 Merge pull request #23457 from Luap99/play-kube-cleanup
fix network cleanup flake in play kube
2024-07-31 14:35:13 -04:00
fcf7cd7d5c Version: bump to v5.3.0-dev
We have v5.2 branch now.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2024-07-31 13:30:35 -04:00
7610cedc80 libpod: inhibit SIGTERM during cleanup()
The network cleanup can handle it when it is killed half way through as
it spits out a bunch of error in that case on the next cleanup attempt.
Try to avoid getting into such a state and ignore sigterm during this
section.

Of course we stil can get SIGKILL so we should work on fixing the
underlying problems in network cleanup but let's see if this helps us
with the CI flakes in the meantime.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-07-31 19:00:16 +02:00