36b41997d0
Merge pull request #20456 from rhatdan/storage
...
not mounted layers should be reported as info not error
2023-10-24 06:33:59 +00:00
1850670f1e
Fix typo
...
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
2023-10-23 23:21:55 -04:00
2e57746ffd
test/apiv2: adapt apiv2 test on cgroups v1 environment
...
Some apiv2 tests are now support on cgroups v1 environment.
Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
2023-10-24 11:52:03 +09:00
c3ba0221ec
ginkgo setup: retry cache pulls
...
Because all registries flake.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-10-23 19:29:18 -06:00
83f07729c8
Merge pull request #20454 from containers/renovate/github.com-vbatts-git-validation-1.x
...
fix(deps): update module github.com/vbatts/git-validation to v1.2.1
2023-10-23 20:42:12 +00:00
3abf5c9291
Merge pull request #20452 from edsantiago/cache_k8s_pause
...
CI: stop using registry.k8s.io
2023-10-23 20:39:08 +00:00
ecb4f487c1
Merge pull request #20446 from Luap99/common
...
vendor latest c/common
2023-10-23 20:35:23 +00:00
ee60708880
Support size option when creating tmpfs volumes
...
Fixes: https://github.com/containers/podman/issues/20449
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-10-23 16:31:54 -04:00
8876380af9
not mounted layers should be reported as info not error
...
There is a potential race condition we are seeing where
we are seeing a message about a removed container which
could be caused by a non mounted container, this change
should clarify which is causing it.
Also if the container does not exists, just warn the user
instead of reporting an error, not much the user can do.
Fixes: https://github.com/containers/podman/issues/19702
[NO NEW TESTS NEEDED]
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-10-23 16:25:13 -04:00
85cc4092fc
CI: stop using registry.k8s.io
...
It's flaky.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-10-23 11:50:41 -06:00
a8e1a5ed1b
fix(deps): update module github.com/vbatts/git-validation to v1.2.1
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-23 17:03:31 +00:00
6d99cb5cd6
test fixes for c/common tag chnages
...
Tag now does a prepend internally instead of append with the names. Thus
the order changed which needs some test changes.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-10-23 15:45:46 +02:00
dfdd933239
vendor latest c/common
...
includes tag/untag changes
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-10-23 11:23:18 +02:00
19c870da0d
Merge pull request #20425 from giuseppe/podman-do-not-leak-DBUS_SESSION_BUS_ADDRESS-into-conmon
...
libpod: skip DBUS_SESSION_BUS_ADDRESS in conmon
2023-10-21 18:36:02 +00:00
3661c87d3c
Merge pull request #20412 from ashley-cui/lastup
...
hyperV: Update lastUp time
2023-10-21 18:05:48 +00:00
8022d696f2
Merge pull request #20427 from Luap99/lint
...
Update dependency golangci/golangci-lint to v1.55.0
2023-10-20 20:32:40 +00:00
d6f44d956d
hyperV: Update lastUp time
...
LastUp now correctly reports the lastUp time for podman machine on
hyperv, for both inspect and list.
Signed-off-by: Ashley Cui <acui@redhat.com>
2023-10-20 15:00:48 -04:00
1ac1108356
[CI:DOCS] Update dependency golangci/golangci-lint to v1.55.0
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-20 16:28:48 +02:00
9e648a1f50
lint: disable testifylint
...
The new linter testifylint reports way to many issues, although they
look like correct findings it is only a small expected vs actual swap
which should not effect the tests other than a (maybe )confusing
error message.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-10-20 16:27:46 +02:00
29273cda10
lint: fix warnings found by perfsprint
...
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-10-20 16:27:46 +02:00
64f43fed4d
lint: fix warnings found by inamedparam
...
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-10-20 16:27:41 +02:00
c21f42a4ed
lint: fix warnings found by protogetter
...
features.GetMemTrack() already does all the pointer checks so we can
just use it.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-10-20 16:26:10 +02:00
03947ab031
libpod: skip DBUS_SESSION_BUS_ADDRESS in conmon
...
commit 7ade9721020468438e822b16ed7a65380cc7fbd2 introduced the change
that caused an issue in crun since it forces the root user session
instead of the system one when DBUS_SESSION_BUS_ADDRESS is set.
I am addressing it in crun, but for the time being, let's also not
pass the variable down to conmon since the assumption is that when
running as root the containers must be created on the system bus.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2023-10-20 16:06:51 +02:00
e49ed78a40
Merge pull request #20385 from umohnani8/host-net
...
Use node hostname in kube play when hostNetwork=true
2023-10-20 12:35:45 +00:00
110914d872
Merge pull request #20359 from containers/renovate/common-image-and-storage-deps
...
fix(deps): update github.com/containers/storage digest to 79aa304
2023-10-20 09:25:49 +00:00
26681c09af
Merge pull request #20414 from edsantiago/perlunicode
...
cirrus setup: special-case perl unicode
2023-10-20 08:27:01 +00:00
37292a10be
Merge pull request #20405 from giuseppe/do-not-leak-sessions-with-remote
...
remote: exec: do not leak session IDs on errors
2023-10-19 20:26:49 +00:00
c1980a6a26
Merge pull request #20409 from Luap99/port-fw
...
[CI:DOCS] network: document ports and macvlan interaction
2023-10-19 19:48:37 +00:00
85e8aa4e83
Merge pull request #20413 from Luap99/quadlet-cgroupv2
...
[CI:DOCS] quadlet: document cgroupv2 requirement
2023-10-19 18:45:23 +00:00
936e30f68b
Use node hostname in kube play when hostNetwork=true
...
When the hostNetwork option is set to true in the k8s yaml,
set the pod's hostname to the name of the machine/node as is
done in k8s. Also set the utsns to host.
Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2023-10-19 12:22:58 -04:00
bd953fdc71
cirrus setup: special-case perl unicode
...
Perl is still stuck in the 1980s. Try to override that.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-10-19 09:30:10 -06:00
ca9efb0cda
network: document ports and macvlan interaction
...
The network backend will ignore ports for macvlan and ipvlan networks so
they do not do anything. No warning or error is shown because containers
may be later connected to a bridge network in which case they would be
useful.
Fixes #17927
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-10-19 17:04:29 +02:00
f2bc638944
quadlet: document cgroupv2 requirement
...
Units created with quadlet need cgroupv2 in order to work.
Fixes #19365
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-10-19 16:39:55 +02:00
0b0f128bfb
Merge pull request #20410 from containers/renovate/actions-checkout-digest
...
[skip-ci] Update actions/checkout digest to b4ffde6
2023-10-19 12:44:12 +00:00
e8183e836c
[skip-ci] Update actions/checkout digest to b4ffde6
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-19 11:14:37 +00:00
1d2589c3f1
Revert "Emergency workaround for CI breakage"
...
This reverts commit 44ed415b2513f1ee9bd6485b923d3de1e91b9aca.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2023-10-19 11:34:36 +02:00
f48a706abc
remote: exec: do not leak session IDs on errors
...
commit fa19e1baa27024f8e0078e27254a8cfb6586f9f4 partially introduced
the fix, but was merged too quickly and didn't work with remote.
Introduce a new binding to allow removing a session from the remote
client.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2023-10-19 11:34:36 +02:00
30b14b33ae
Merge pull request #20403 from containers/renovate/k8s.io-kubernetes-1.x
...
fix(deps): update module k8s.io/kubernetes to v1.28.3
2023-10-19 09:34:09 +00:00
c2e1debe8d
Merge pull request #20395 from rhatdan/quadlet
...
Allow systemd specifiers in User and Group Quadlet keys
2023-10-19 09:28:12 +00:00
ad1ab71b8c
fix(deps): update github.com/containers/storage digest to 79aa304
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-19 08:24:49 +00:00
d1086281bb
fix(deps): update module k8s.io/kubernetes to v1.28.3
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-19 07:44:35 +00:00
68636416d7
Merge pull request #20357 from rhatdan/TERM
...
Add TERM iff TERM not defined in container when podman exec -t
2023-10-18 23:50:41 +00:00
b2192695bc
Merge pull request #20406 from edsantiago/systest_bork
...
System tests: fix broken silence127
2023-10-18 22:16:28 +00:00
657029da78
System tests: fix broken silence127
...
Followup to #20394 . For years (since BATS 1.5) we've been
seeing and ignoring nasty red warnings at the end of every
system test run. Thanks for fixing it, @giuseppe! But it
broke down in the '?' case when $expected_rc is empty:
test/system/helpers.bash: line 345: [: -eq: unary operator expected
Simple fix.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-10-18 14:33:25 -06:00
9a29eb05ef
Merge pull request #20400 from baude/issue20361
...
Fix path for omvf vars on Darwin/arm64
2023-10-18 20:07:53 +00:00
b72bb11629
Add TERM iff TERM not defined in container when podman exec -t
...
Fixes: https://github.com/containers/podman/issues/20334
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-10-18 15:40:52 -04:00
d4086f5ac4
Merge pull request #20404 from edsantiago/emergency_ci_fix
...
Emergency workaround for CI breakage
2023-10-18 19:24:38 +00:00
6c7104c4fe
Merge pull request #20402 from baude/applehvrmstopgvproxy
...
Kill gvproxy when machine rm -f
2023-10-18 19:18:32 +00:00
44ed415b25
Emergency workaround for CI breakage
...
Skip new exec-leak test
Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-10-18 12:07:55 -06:00
62a81a166a
Merge pull request #20383 from Luap99/init-path
...
use FindInitBinary() for init binary
2023-10-18 17:17:59 +00:00
