14610 Commits

Author SHA1 Message Date
6d2b54a731 Merge pull request #13197 from giuseppe/doc-cannot-write-loginuid
[CI:DOCS] troubleshooting: add doc for ssh into a container
2022-02-10 13:37:59 -05:00
0144413a5a Merge pull request #13191 from mheon/resolvconf_fixes
Modify /etc/resolv.conf when connecting/disconnecting
2022-02-10 12:24:03 -05:00
a0b38c071b troubleshooting: add doc for ssh into a container
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-02-10 17:08:54 +01:00
87cca4e5e3 Modify /etc/resolv.conf when connecting/disconnecting
The `podman network connect` and `podman network disconnect`
commands give containers access to different networks than the
ones they were created with; these networks can also have DNS
servers associated with them. Until now, however, we did not
modify resolv.conf as network membership changed.

With this PR, `podman network connect` will add any new
nameservers supported by the new network to the container's
/etc/resolv.conf, and `podman network disconnect` command will do
the opposite, removing the network's nameservers from
`/etc/resolv.conf`.

Fixes #9603

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2022-02-10 09:44:00 -05:00
9cf1b1bd2f Merge pull request #13178 from vrothberg/sym-hello
helloimage: header symmetry
2022-02-10 09:11:58 -05:00
64a73686b9 Merge pull request #13189 from jwhonce/wip/network_version
Add version guard to libpod API endpoints
2022-02-10 09:09:56 -05:00
0585aaa1f1 Merge pull request #13192 from TomSweeneyRedHat/dev/tsweeney/bumpcommon
Bump c/common to v0.47.4
2022-02-10 09:07:56 -05:00
c4676c5719 Add version guard to libpod API endpoints
* Ensure meaningful behaviour when called with /v3.x.x semantics
* Change return code to 409 from 500 when client attempts to use an
  existing network name
* Update API bats test runner to support /v4.0.0 endpoints by default

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2022-02-09 14:22:42 -07:00
1512740e3b Bump c/common to v0.47.4
As the title says.

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2022-02-09 15:26:51 -05:00
12836a5610 Merge pull request #13184 from Luap99/cni-dir
Do not set the network config dir to cni plugin dir
2022-02-09 14:51:53 -05:00
cd9ec7f7c3 Merge pull request #13182 from Luap99/api-doc
[CI:DOCS] Show API doc for several versions
2022-02-09 12:59:51 -05:00
829f88d74d Show API doc for several versions
Right now it is not possible to look at the API version for a specific
version. docs.podman.io always show the latest version from the main
branch. This is not want many users want so they now have the ability to
select a different version.

Fixes #12796

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-02-09 18:17:52 +01:00
3762946e63 Do not set the network config dir to cni plugin dir
I do not know why this code was added but it is wrong. We should never
use a plugin dir as config dir. Also this will fail for netavark. The
correct default will be set in c/common so podman should not touch it.

[NO NEW TESTS NEEDED]

Ref #13183

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-02-09 16:18:21 +01:00
411fca0b3d helloimage: header symmetry
Make the header symmetric by adding a whitespace before the `!` on the
righthand side.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2022-02-09 14:57:16 +01:00
eb0a0db318 Merge pull request #13142 from tmds/ImageCreate_200_schema
[CI:DOCS] Add schema for ImageCreate 200 response.
2022-02-09 04:45:13 -05:00
e405fefb31 [NO NEW TEST NEEDED] Add schema for ImageCreate 200 response.
Signed-off-by: Tom Deseyn <tom.deseyn@gmail.com>
2022-02-09 10:12:47 +01:00
b92846b42f Merge pull request #13170 from rhatdan/idmap
idmap should be able to be specified along with other options
2022-02-09 03:51:09 -05:00
61f97083c6 idmap should be able to be specified along with other options
[NO NEW TESTS NEEDED] crun is not available everywhere to test idmap.
Kernel might not be recent enough and not all file systems support
idmap option.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-02-08 17:08:49 -05:00
6ffd59828d Merge pull request #13164 from containers/dependabot/go_modules/github.com/docker/distribution-2.8.0incompatible
Bump github.com/docker/distribution from 2.7.1+incompatible to 2.8.0+incompatible
2022-02-08 11:02:21 -05:00
119f8bc6c7 Merge pull request #13163 from myml/myml/fix-duration
fix: Multiplication of durations
2022-02-08 10:58:20 -05:00
cbd0980d5b Merge pull request #13159 from Luap99/slirp4-scope
move rootless netns slirp4netns process to systemd user.slice
2022-02-08 07:10:15 -05:00
5bcd9134ff Bump github.com/docker/distribution
Bumps [github.com/docker/distribution](https://github.com/docker/distribution) from 2.7.1+incompatible to 2.8.0+incompatible.
- [Release notes](https://github.com/docker/distribution/releases)
- [Commits](https://github.com/docker/distribution/compare/v2.7.1...v2.8.0)

---
updated-dependencies:
- dependency-name: github.com/docker/distribution
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-08 12:09:28 +00:00
58adf1a835 fix: Multiplication of durations
'killContainerTimeout' is already 5 second
[NO NEW TESTS NEEDED]

Signed-off-by: myml <wurongjie1@gmail.com>
2022-02-08 09:15:45 +08:00
8d0fb0a4ed move rootless netns slirp4netns process to systemd user.slice
When running podman inside systemd user units, it is possible that
systemd kills the rootless netns slirp4netns process because it was
started in the default unit cgroup. When the unit is stopped all
processes in that cgroup are killed. Since the slirp4netns process is
run once for all containers it should not be killed. To make sure
systemd will not kill the process we move it to the user.slice.

Fixes #13153

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-02-07 17:38:53 +01:00
46d9a2570a Merge pull request #13156 from flouthoc/fix-compat-build-response-header
compat: endpoint `/build` must set header `content type` as `application/json` in response header.
2022-02-07 10:34:22 -05:00
30b076b987 Merge pull request #13158 from edsantiago/bats
Cleanup: remove obsolete/misleading bug workaround
2022-02-07 10:28:22 -05:00
d0d1ffa43e Cleanup: remove obsolete/misleading bug workaround
Followup to #13129: remove a no-longer-necessary workaround
for a healthcheck bug.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-02-07 06:58:19 -07:00
b1dcd025c6 Merge pull request #13129 from flouthoc/healthcheck-session-read-from-pipe
healthcheck, libpod: Read healthcheck event output from os pipe
2022-02-07 08:52:23 -05:00
f6b0abfa8a Merge pull request #13155 from myml/main
Fix: Do not print error when parsing journald log fails
2022-02-07 08:20:17 -05:00
3b561a4682 compat: endpoint /build must set header content type as application/json in reponse
Lot of clients are expecting proper `Content-type: application/json`
configured in response headers of `/build` compat api. Following commit
fixes that.

Fixes issues where code is setting header field after writing header
which is wrong. We must set `content-type` before we write and flush
http header.

Signed-off-by: Aditya R <arajan@redhat.com>
2022-02-07 13:38:19 +05:30
44fb431a3c Fix: Do not print error when parsing journald log fails
foramtError was written as err
[NO NEW TESTS NEEDED]

Signed-off-by: myml <wurongjie1@gmail.com>
2022-02-07 13:59:25 +08:00
ab4af502b3 Merge pull request #13147 from cevich/more_netavark
Cirrus: Expand netavark testing to include rootless
2022-02-04 13:23:09 -05:00
8c5b47f459 Merge pull request #13146 from cevich/dependabot_goterm
Bump github.com/buger/goterm from 1.0.1 to 1.0.4
2022-02-04 13:21:07 -05:00
ec390d5d35 Merge pull request #13143 from Luap99/dns
append podman dns search domain
2022-02-04 11:49:11 -05:00
f0826b3a49 Cirrus: Expand netavark testing to include rootless
The list of netavark/aardvark-dns tasks is likely to be
ever-growing for the near-term.  Consolidate them into a single task
entry with a matrix attribute to make future expansions less
YAML-duplicative.  Also, re-arrange it to fall in-between the CNI
integration and system task sections.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-02-04 11:41:26 -05:00
3cf64a8e9a tests: retrofit healthcheck system tests
All the healthcheck return output now but systems tests is written to
expect empty output which seems wrong.

Modify jq output to contain newline character rather than actual newline

Signed-off-by: Aditya R <arajan@redhat.com>
2022-02-04 21:15:15 +05:30
4f77331c9d healthcheck, libpod: Read healthcheck event output from os pipe
It seems we are ignoring output from healthcheck session.
Open a valid pipe to healthcheck session in order read its output.

Use common pipe for both `stdout/stderr` since that was the previous
behviour as well.

Signed-off-by: Aditya R <arajan@redhat.com>
2022-02-04 21:15:03 +05:30
d733c3baa2 append podman dns search domain
Append the podman dns seach domain to the host search domains when we
use the dnsname/aardvark server. Previously it would only use podman
seach domains and discard the host domains.

Fixes #13103

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-02-04 16:16:06 +01:00
956664f65b Merge pull request #12930 from cdoern/podCgroup
Podman pod create --share-parent vs --share=cgroup
2022-02-04 09:41:12 -05:00
2a48a88629 Merge pull request #13134 from edsantiago/bats
System tests: revert emergency skip of checkpoint tests
2022-02-04 09:39:11 -05:00
320e2935c8 Merge pull request #13136 from rhatdan/VENDOR
Update containers/buildah v1.24.1
2022-02-04 08:53:42 -05:00
54cf0f05e3 Bump github.com/buger/goterm from 1.0.1 to 1.0.4
Bumps [github.com/buger/goterm](https://github.com/buger/goterm) from 1.0.1 to 1.0.4.
- [Release notes](https://github.com/buger/goterm/releases)
- [Commits](https://github.com/buger/goterm/compare/v1.0.1...v1.0.4)

---
updated-dependencies:
- dependency-name: github.com/buger/goterm
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-04 12:08:41 +00:00
1d1b2b1509 Update containers/buildah v1.24.1
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-02-03 18:33:22 -05:00
7cfe4d3fe7 System tests: revert emergency skip of checkpoint tests
Revert #13049. criu-3.16.1-6.fc36 fixes the problem and is
now in fc36 stable:

   https://bodhi.fedoraproject.org/updates/FEDORA-2022-183b337712

(Yes, I confirmed that tests pass on a rawhide vm)

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-02-03 14:48:35 -07:00
608b6142ed Merge pull request #13024 from cevich/netavark_system
Cirrus: Add netavark/aardvark system test task
2022-02-03 15:37:19 -05:00
e1ed5a9d9c Merge pull request #13131 from containers/dependabot/go_modules/github.com/containers/common-0.47.3
Bump github.com/containers/common from 0.47.2 to 0.47.3
2022-02-03 15:35:08 -05:00
185dc5b2f3 Bump github.com/containers/common from 0.47.2 to 0.47.3
Bumps [github.com/containers/common](https://github.com/containers/common) from 0.47.2 to 0.47.3.
- [Release notes](https://github.com/containers/common/releases)
- [Commits](https://github.com/containers/common/compare/v0.47.2...v0.47.3)

---
updated-dependencies:
- dependency-name: github.com/containers/common
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-03 18:39:37 +00:00
e30edd6d8e Merge pull request #13127 from containers/dependabot/go_modules/github.com/containers/image/v5-5.19.1
Bump github.com/containers/image/v5 from 5.19.0 to 5.19.1
2022-02-03 13:14:41 -05:00
642a691cbb Cirrus: Add netavark/aardvark system test task
Also add a system-test that verifies netavark driver is in use when
magic env. var. is set.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-02-03 13:07:56 -05:00
daf51eafee Bump github.com/containers/image/v5 from 5.19.0 to 5.19.1
Bumps [github.com/containers/image/v5](https://github.com/containers/image) from 5.19.0 to 5.19.1.
- [Release notes](https://github.com/containers/image/releases)
- [Commits](https://github.com/containers/image/compare/v5.19.0...v5.19.1)

---
updated-dependencies:
- dependency-name: github.com/containers/image/v5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-03 16:25:23 +00:00