Commit Graph

24629 Commits

Author SHA1 Message Date
Paul Holzinger
04dffbc2c7 cirrus: change alt arch task to only compile binaries
The current podman-release-%.tar.gz target does a lot more then just
checking if we can build for the given arch, in particular it first
builds a local podman-remote for the remote-docs.sh script. This makes
things slow as we compile several things and then builda and package the
docs. Given the docs are not arch specific there is realy no point in
doing all that work. All we care about is if the bianries can build on
other arches to catch compile issue for otherwise untested arches.

This should make the CI Alt Arch. tasks much faster.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-10-11 11:25:33 +02:00
Paul Holzinger
9082a14d76 cirrus: run make with parallel jobs where useful
The doc generation and the validate-binaries target can be run in
parallel as they do not depend on each other and a specific ordering. As
such we pass -j $(nproc) but also --output-sync=target to ensure the
output is not intermixed between several targets which could be harder
to read in case of errors.

Hower dus the complex podman-release target we can run podman-release
and validate-binaries at the same time as the dependencies are not right
and we run podman-release first in order to get the correct binaires
build.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-10-11 11:25:33 +02:00
Paul Holzinger
bc3db7c95b Makefile: allow man-page-check to be run in parallel
This target runs several scripts in serial but they do not have any
dependencies so we can split them all into their own target so that make
-j can run the targets in parallel to speed this up.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-10-11 11:25:33 +02:00
Paul Holzinger
39963cc984 cirrus: use fastvm for builds
Builds now take over 10 mins, given golang compilation is parallelized
by default we can give more cores to speed it up.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-10-11 11:25:33 +02:00
openshift-merge-bot[bot]
d512e44147 Merge pull request #24227 from Luap99/ci-image-update
cirrus: update CI images
2024-10-10 17:25:39 +00:00
Paul Holzinger
4e3a03795d test/e2e: skip some Containerized checkpoint tests
They no longer work in the latest image update, it is not clear why and
I do not have the time to debug that stuff. I opened #24230 to track it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-10-10 17:44:09 +02:00
Paul Holzinger
fe404959ed test: update timezone checks
In debian EST and MST7MDT are gone by default and moved to a special
package[1], instead of also installing that in the images lets use
different timezones in the test.

[1] 42c0008f86

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-10-10 17:44:08 +02:00
openshift-merge-bot[bot]
569d005b34 Merge pull request #24225 from Luap99/pasta-hang
test/e2e: try debug potential pasta issue
2024-10-10 12:28:26 +00:00
Paul Holzinger
a79fec5e98 cirrus: update CI images
Images from https://github.com/containers/automation_images/pull/387

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-10-10 14:19:25 +02:00
Paul Holzinger
f517e52167 test/e2e: try debug potential pasta issue
Run pasta with --trace and a log file to see if the hangs are caused by
pasta not correctly closing connections as assumed in #24219.

As the log is super verbose do not log it by default so I added some
extra logic to make sure it is only logged when the test fails.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-10-10 12:00:25 +02:00
openshift-merge-bot[bot]
9a887d1600 Merge pull request #24221 from edsantiago/fix-sizerootfs-flake
CI: quadlet system tests: use airgapped testimage
2024-10-10 00:15:13 +00:00
Ed Santiago
38803713d6 CI: quadlet system tests: use airgapped testimage
This command sequence causes SizeRootFs to change on foo:

   podman tag foo newimagename
   podman save ... newimagename
   podman load ...

Solution: get foo completely out of the picture. Use an
airgapped image: new image, new digest, new everything.

Fixes: #23756

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-10-09 14:11:00 -06:00
openshift-merge-bot[bot]
5890190c59 Merge pull request #24194 from lambinoo/quadlet-disable-default-dependencies
Allow removing implicit quadlet systemd dependencies
2024-10-09 16:23:31 +00:00
Farya L. M
bac655a6b1 Allow removing implicit quadlet systemd dependencies
Quadlet inserts network-online.target Wants/After dependencies to ensure pulling works.
Those systemd statements cannot be subsequently reset.

In the cases where those dependencies are not wanted, we add a new
configuration item called `DefaultDependencies=` in a new section called
[Quadlet]. This section is shared between different unit types.

fixes #24193

Signed-off-by: Farya L. Maerten <me@ltow.me>
2024-10-09 14:48:05 +02:00
openshift-merge-bot[bot]
3460ec496c Merge pull request #24212 from containers/renovate/github.com-cyphar-filepath-securejoin-0.x
fix(deps): update module github.com/cyphar/filepath-securejoin to v0.3.4
2024-10-09 08:40:05 +00:00
renovate[bot]
05a449c61e fix(deps): update module github.com/cyphar/filepath-securejoin to v0.3.4
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-09 04:53:26 +00:00
openshift-merge-bot[bot]
b997841bde Merge pull request #24208 from Luap99/remote-wait
Improve podman-remote run --rm exit code handling
2024-10-08 17:43:40 +00:00
openshift-merge-bot[bot]
a4e098ae79 Merge pull request #24163 from slp/update-krunkit-0.1.3
Bump bundled krunkit to 0.1.3
2024-10-08 17:35:19 +00:00
Paul Holzinger
b3829a2932 libpod API: make wait endpoint better against rm races
In the common scenario of podman-remote run --rm the API is required to
attach + start + wait to get exit code. This has the problem that the
wait call races against the container removal from the cleanup process
so it may not get the exit code back. However we keep the exit code
around for longer than the container so  we can just look it up in the
endpoint. Of course this only works when we get a full id as param but
podman-remote will do that.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-10-08 18:03:15 +02:00
Paul Holzinger
3215d5124f podman-remote run: improve how we get the exit code
Call the wait endpoint right away when a container is started and not
only when attach is done, this allows us for wait to work when the
container has been removed otherwise (i.e. podman-remote run --rm). In
that case it was possible that wait failed and we then fall back to
reading events. However based on some reports there seems to be the
chance that the event readin is not working for them either and returns
a bad error "Cannot get exit code: <nil>" which does not help anybody.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-10-08 18:03:11 +02:00
openshift-merge-bot[bot]
07da6313c4 Merge pull request #24195 from edsantiago/055-cleanup
055-rm test: clean up a test, and document
2024-10-08 12:34:53 +00:00
openshift-merge-bot[bot]
7652e04398 Merge pull request #24202 from lsm5/packit-koji-build-constraint
[skip-ci] Packit: constrain koji and bodhi jobs to fedora package to avoid dupes
2024-10-08 11:09:37 +00:00
openshift-merge-bot[bot]
c8805f24c5 Merge pull request #24188 from containers/renovate/google.golang.org-protobuf-1.x
fix(deps): update module google.golang.org/protobuf to v1.35.0
2024-10-08 10:58:37 +00:00
Lokesh Mandvekar
3d1a4301af [skip-ci] Packit: constrain koji and bodhi jobs to fedora package to avoid dupes
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2024-10-08 16:04:16 +05:30
openshift-merge-bot[bot]
6d3ebe67f0 Merge pull request #24117 from containers/renovate/github.com-shirou-gopsutil-v4-4.x
fix(deps): update module github.com/shirou/gopsutil/v4 to v4.24.9
2024-10-08 10:22:52 +00:00
Ed Santiago
e7833d52cf 055-rm test: clean up a test, and document
There's an important reason why the healthcheck container in 055-rm
test uses 'sleep infinity' and not 'top. Document it.

And, the test itself wasn't actually working as intended. Make
it safer by confirming that the container actually enters
the "stopping" state.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-10-07 15:22:49 -06:00
Sergio Lopez
3cedd0c2b5 CI: remove skips for libkrun
Remove the skips introduced to work around #23296

Signed-off-by: Sergio Lopez <slp@redhat.com>
2024-10-07 19:41:20 +02:00
Sergio Lopez
858472aa83 Bump bundled krunkit to 0.1.3
Bump the bundled krunkit version from 0.1.2 to 0.1.3.

Fixes: #23296

Signed-off-by: Sergio Lopez <slp@redhat.com>
2024-10-07 19:41:20 +02:00
openshift-merge-bot[bot]
6b0ad8269c Merge pull request #24182 from containers/renovate/golang.org-x-tools-0.x
fix(deps): update module golang.org/x/tools to v0.26.0
2024-10-07 16:59:17 +00:00
renovate[bot]
43a4bddd10 fix(deps): update module google.golang.org/protobuf to v1.35.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-07 13:11:58 +00:00
openshift-merge-bot[bot]
e71d8a36e5 Merge pull request #24183 from Luap99/info-socket-url
server: fix url parsing in info
2024-10-07 13:10:36 +00:00
openshift-merge-bot[bot]
35768aef2b Merge pull request #24173 from containers/renovate/golang.org-x-net-0.x
fix(deps): update module golang.org/x/net to v0.30.0
2024-10-07 11:29:55 +00:00
renovate[bot]
385e2ea650 fix(deps): update module golang.org/x/net to v0.30.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-07 10:26:51 +00:00
openshift-merge-bot[bot]
741818e010 Merge pull request #24172 from containers/renovate/golang.org-x-crypto-0.x
fix(deps): update module golang.org/x/crypto to v0.28.0
2024-10-07 10:15:39 +00:00
Paul Holzinger
45df394072 server: fix url parsing in info
When we are activated by systemd the code assumed that we had a valid
URL which was not the case so it failed to parse the URL which causes
the info call to fail all the time.
This fixes two problems first add the schema to the systemd activated
listener URL so it can be parsed correctly but second simply do not
parse it as url as all we care about in the info call is if it is unix
and the file path exists.

Fixes #24152

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-10-07 12:03:56 +02:00
renovate[bot]
b8dbe09f98 fix(deps): update module golang.org/x/tools to v0.26.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-07 10:00:55 +00:00
openshift-merge-bot[bot]
1867ecc96a Merge pull request #24171 from containers/renovate/github.com-mattn-go-sqlite3-1.x
fix(deps): update module github.com/mattn/go-sqlite3 to v1.14.24
2024-10-07 10:00:04 +00:00
Paul Holzinger
e2e1996c6a Makefile: fix ginkgo FOCUS option
This fixes a regression that causes the FOCUS option to not work
correctly as the --silence-skips is passes to --focus not as extra
option.

Fixes 23f256349b ("Makefile - silence skipped tests when focusing on a file")

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-10-07 11:56:41 +02:00
openshift-merge-bot[bot]
95a55f971c Merge pull request #24177 from eriksjolund/docs-prefer-option-network
docs: prefer --network to --net
2024-10-07 09:18:50 +00:00
renovate[bot]
fbd9fe45cb fix(deps): update module golang.org/x/crypto to v0.28.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-07 09:17:57 +00:00
openshift-merge-bot[bot]
67570fb208 Merge pull request #24178 from eriksjolund/fix-issue23954
podman-systemd.unit.5: adjust example options
2024-10-07 09:16:05 +00:00
Erik Sjölund
d0cb62aacc podman-systemd.unit.5: adjust example options
Use the reserved domain name example.com in the examples.
For details, see RFC 2606
https://datatracker.ietf.org/doc/html/rfc2606#section-3

Modify PublishPort examples to make them reflect more
common scenarios.

Fixes: https://github.com/containers/podman/issues/23954

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2024-10-06 17:31:41 +02:00
Erik Sjölund
374844817d docs: prefer --network to --net
The option --network is the more official option as it is
listed in

podman run --help
podman kube play --help

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2024-10-05 09:10:15 +02:00
openshift-merge-bot[bot]
8d5ec11d0b Merge pull request #24175 from containers/renovate/golang.org-x-term-0.x
fix(deps): update module golang.org/x/term to v0.25.0
2024-10-04 22:55:41 +00:00
renovate[bot]
1470961e6c fix(deps): update module golang.org/x/term to v0.25.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-10-04 21:32:59 +00:00
openshift-merge-bot[bot]
e6f530b4b3 Merge pull request #24170 from containers/renovate/golang.org-x-sys-0.x
fix(deps): update module golang.org/x/sys to v0.26.0
2024-10-04 17:06:13 +00:00
openshift-merge-bot[bot]
d28af234de Merge pull request #24164 from mheon/host_network_no_expose_in_ports
Exposed ports are only included when not --net=host
2024-10-04 17:03:40 +00:00
openshift-merge-bot[bot]
4b958b3fa0 Merge pull request #24169 from baude/OWNERS.update
OWNERS file audit and update
2024-10-04 17:01:24 +00:00
openshift-merge-bot[bot]
17d29a2f6d Merge pull request #24122 from PhrozenByte/docs-hosts-file
Mention `no_hosts` and `base_hosts_file` configs in CLI option docs
2024-10-04 16:58:13 +00:00
openshift-merge-bot[bot]
1f7fe1d1e8 Merge pull request #24167 from giuseppe/improve-check-for-current-user-mapped
libpod: hasCurrentUserMapped checks for gid too
2024-10-04 16:55:13 +00:00