Commit Graph

21544 Commits

Author SHA1 Message Date
Ed Santiago
4508620545 xref-manpages script: more regression tests
Followup to #21055: regression tests for the code that
reads man pages. These are not xref-related at all, just
simple consistency checks on the man page content.

In the process of writing these tests, I also fixed a
longstanding bug where warning messages could be emitted
multiple times, once for each time we read a man page file
(as happens with command aliases).

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-01-04 09:35:37 -07:00
Urvashi Mohnani
e63513542b Vendor latest c/image
Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2024-01-04 10:09:47 -05:00
Jake Correnti
98f332d482 Use parser.UnitFile
Uses the systemd unit file parser to build unit files instead of having
them be just blocks of hard-coded strings.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2024-01-04 08:51:35 -05:00
Jake Correnti
c728eeb39e Create pkg/machine/ignition package
Moves all of the ignitionfiles out of the `machine` package and into
its own called `ignition`. This required `VMType` to get moved out of
the `machine` package and into the `define` package in order to prevent
a circular dependency.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2024-01-04 08:51:35 -05:00
openshift-merge-bot[bot]
de797e5724 Merge pull request #21142 from ygalblum/quadlet-stop-params
Quadlet - add StopTimeout key for .container file
2024-01-04 11:53:31 +00:00
openshift-merge-bot[bot]
94da6397e7 Merge pull request #21149 from cgwalters/machine-debugging
machine/qemu: A few debugging prints
2024-01-04 11:50:49 +00:00
openshift-merge-bot[bot]
0587a00949 Merge pull request #21154 from alexandear/chore-remove-obsolete-build-constraints
chore: delete obsolete // +build lines
2024-01-04 11:48:02 +00:00
Oleksandr Redko
560455cbd6 docs: fix typos
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
2024-01-04 12:10:11 +02:00
Oleksandr Redko
2a2d0b0e18 chore: delete obsolete // +build lines
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
2024-01-04 11:53:38 +02:00
openshift-merge-bot[bot]
11c0277cd6 Merge pull request #21146 from cgwalters/label-machine
[CI:DOCS] ci: Automatically add "podman machine" label
2024-01-03 22:13:39 +00:00
openshift-merge-bot[bot]
7d131b8e11 Merge pull request #21145 from baude/appledarwindefault
Set applehv as default darwin provider
2024-01-03 22:10:54 +00:00
Colin Walters
92f3bacc65 machine/qemu: A few debugging prints
I was trying to debug a failure which was seemingly related
to gvproxy failing which I now can't reproduce,
and added these while working on it.  Maybe they're useful in
the future.

[NO NEW TESTS NEEDED]

Signed-off-by: Colin Walters <walters@verbum.org>
2024-01-03 17:06:34 -05:00
Colin Walters
876b2207ee ci/labeler: Add area/machine label
Because I want to track this sub-area myself.

Signed-off-by: Colin Walters <walters@verbum.org>
2024-01-03 14:04:26 -05:00
Brent Baude
f5a986f4ee Set applehv as default darwin provider
Podman 5 will not support QEMU on darwin anymore.  This PR only changes the default from `qemu` to `applehv`.  Code changes to enforce not supporting qemu will come later.

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <baude@redhat.com>
2024-01-03 12:05:09 -06:00
Ygal Blum
689d97a1d1 Quadlet - add StopTimeout key for .container file
Allow setting the timeout for stopping the container
Add test
Update man

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2024-01-03 18:38:38 +02:00
openshift-merge-bot[bot]
185fa5ba3f Merge pull request #21103 from fj-tsubasa/remote-kube-play-publish-all
remote: fix podman-remote kube play --publish-all
2024-01-03 12:41:41 +00:00
openshift-merge-bot[bot]
490e5ed1a6 Merge pull request #21129 from edsantiago/new_vms
CI: bump VMs
2024-01-03 12:16:54 +00:00
openshift-merge-bot[bot]
45c3e76fe6 Merge pull request #21110 from cgwalters/doc-external-gvproxy
[CI:DOCS] docs/build_osx.md: Describe external gvproxy
2024-01-03 08:14:55 +00:00
yyzxw
ac0353aec9 chore: remove unused link
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io>
2024-01-03 09:29:58 +08:00
Ed Santiago
8c546cf7ee CI: bump VMs
All VMs have pasta 2023-12-04, so, remove a skip.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-01-02 16:10:35 -07:00
openshift-merge-bot[bot]
4f8154ca16 Merge pull request #21123 from containers/renovate/github.com-shirou-gopsutil-v3-3.x
fix(deps): update module github.com/shirou/gopsutil/v3 to v3.23.12
2024-01-02 18:46:14 +00:00
Colin Walters
f9de9809e3 docs/build_osx.md: Describe external gvproxy
I think many podman-MacOS developers will fit into what this
doc section describes.

Signed-off-by: Colin Walters <walters@verbum.org>
2024-01-02 13:31:30 -05:00
openshift-merge-bot[bot]
8366cdccfe Merge pull request #21121 from ygalblum/makefile-install-git-validation
Makefile - make sure gitvalidation is installed before calling it
2024-01-02 12:59:43 +00:00
openshift-merge-bot[bot]
04548815fc Merge pull request #21114 from baude/applehvIsValid
applehv - fix vm lookup
2024-01-02 12:56:59 +00:00
openshift-merge-bot[bot]
a8c8704664 Merge pull request #21112 from ygalblum/quadlet-multiline-trailing-whitespaces
Quadlet - fix trailing whitespaces handling
2024-01-02 12:54:13 +00:00
renovate[bot]
5827ecb42e fix(deps): update module github.com/shirou/gopsutil/v3 to v3.23.12
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-01-02 12:36:51 +00:00
openshift-merge-bot[bot]
abe13a06ee Merge pull request #21059 from containers/renovate/go-golang.org/x/crypto-vulnerability
chore(deps): update module golang.org/x/crypto to v0.17.0 [security]
2024-01-02 12:34:59 +00:00
Ygal Blum
70a53cb76a Quadlet - fix trailing whitespaces handling
Remove all trailing white spaces from all lines before the line by line
processing
Add test
Exclude the unit file used for the test from whitespace check

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2024-01-02 12:26:44 +02:00
Ygal Blum
c315c8e74e Makefile - make sure gitvalidation is installed before calling it
[NO NEW TESTS NEEDED]

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2024-01-02 12:09:12 +02:00
openshift-merge-bot[bot]
5657e32726 Merge pull request #21084 from ygalblum/kube-generate-bind-mount-annotation
Kube Generate - check options in bind-mount-options exist before accessing
2024-01-02 08:27:42 +00:00
Brent Baude
55b08d3bad applehv - fix vm lookup
small correction to properly lookup a applehv vm on disk.

Fixes: #21090

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <baude@redhat.com>
2024-01-01 14:33:30 -06:00
openshift-merge-bot[bot]
8dcd3b221c Merge pull request #21089 from bc-lee/feature/podman-machine-mount-mmap
Add mmap cache option to QEMU mount
2024-01-01 19:51:13 +00:00
openshift-merge-bot[bot]
4419924150 Merge pull request #21107 from fj-tsubasa/e2e-systemd_test-journald
e2e: Skip journalctl if journald is unavailable
2024-01-01 19:48:26 +00:00
Tsubasa Watanabe
ec5422af5b e2e: Skip journalctl if journald is unavailable
Test "podman start container by systemd" is failed on the system in
which rootless users don't have accessibility to journald. Therefore,
skip the part that reads journal with journalctl.

Signed-off-by: Tsubasa Watanabe <w.tsubasa@fujitsu.com>
2023-12-31 15:27:53 +09:00
Tsubasa Watanabe
4f94c96b9b remote: fix podman-remote kube play --publish-all
Fix `podman kube play --publish-all` to work in remote environment.

Signed-off-by: Tsubasa Watanabe <w.tsubasa@fujitsu.com>
2023-12-29 12:41:54 +09:00
Ygal Blum
4083ddbb00 Kube Generate - check options in bind-mount-options exist before accessing
Verify that the separator ':' was found before splitting the string

[NO NEW TESTS NEEDED]

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2023-12-26 18:13:41 +02:00
Byoungchan Lee
f10a7bfd4c Add mmap cache option to QEMU mount
This is required for mmap'ing on mounted files on MacOS Host.
Closes #19639, #20055.

Signed-off-by: Byoungchan Lee <daniel.l@hpcnt.com>
2023-12-26 18:37:10 +09:00
Daniel J Walsh
7dc7cbfd9b Merge pull request #21067 from containers/renovate/go-github.com/containerd/containerd-vulnerability
chore(deps): update module github.com/containerd/containerd to v1.7.11 [security]
2023-12-22 07:58:16 -05:00
renovate[bot]
2fc862d391 chore(deps): update module github.com/containerd/containerd to v1.7.11 [security]
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-12-20 15:50:20 +00:00
openshift-merge-bot[bot]
65266a3892 Merge pull request #21055 from edsantiago/xref_tests
[CI:DOCS] Tests for xref-helpmsgs-manpages
2023-12-19 12:27:39 +00:00
openshift-merge-bot[bot]
551e3c56de Merge pull request #21030 from containers/renovate/github.com-vbauerster-mpb-v8-8.x
Update module github.com/vbauerster/mpb/v8 to v8.7.1
2023-12-19 12:24:30 +00:00
renovate[bot]
90b09b5869 chore(deps): update module golang.org/x/crypto to v0.17.0 [security]
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-12-19 12:11:58 +00:00
openshift-merge-bot[bot]
6a65597358 Merge pull request #21053 from rhatdan/VERSION
Move golang requirement from 1.18 to 1.20
2023-12-19 12:10:46 +00:00
openshift-merge-bot[bot]
d161cf32fb Merge pull request #21046 from gavinkflam/improve-test-compose
Improve compose tests to report test errors as failures
2023-12-18 20:35:44 +00:00
Ed Santiago
f90b4e79a6 Tests for xref-helpmsgs-manpages
In the process of adding new functionality to the xref script,
I realized it is much too fragile. It's too easy to make some
minor change that could break the crossrefs, giving us the
illusion of testing.

Solution: add a test suite for the script. Still incomplete,
but an important step toward building confidence.

Requires minor surgery to the script itself

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-12-18 13:33:07 -07:00
openshift-merge-bot[bot]
26bcffd7a1 Merge pull request #21017 from giuseppe/fix-podman-info-twice
abi: drop check for IsRootless()
2023-12-18 20:32:59 +00:00
openshift-merge-bot[bot]
de3c02ab46 Merge pull request #21039 from rhatdan/pods
Allow PublishPorts to be used with [Pod] entry
2023-12-18 20:30:15 +00:00
Giuseppe Scrivano
1322f3193b abi: drop check for IsRootless()
it is the wrong check to do here since we need to setup the user
namespace even in the case we are running as root without
capabilities.

[NO NEW TESTS NEEDED] this happens in nested podman

Closes: https://github.com/containers/podman/issues/20908

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2023-12-18 14:05:30 +01:00
Daniel J Walsh
9d0da9d0fd Strip key/values of external quotes
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-12-18 08:03:26 -05:00
openshift-merge-bot[bot]
c324dbb8b4 Merge pull request #21049 from k9withabone/quadlet-ulimit-multiple
quadlet container support multiple Ulimit options
2023-12-18 12:38:22 +00:00