2816 Commits

Author SHA1 Message Date
39ef6d43d0 Merge pull request #1756 from isimluk/update-dependent-metalinter
Update metalinter dependency
2018-11-16 05:02:03 -08:00
53c47b9061 Merge pull request #1769 from umohnani8/build
Set --force-rm for podman build to true by default
2018-11-16 03:04:58 -08:00
c1bc0a7192 Add a rule to compile system test in Makefile
Signed-off-by: Yiqiao Pu <ypu@redhat.com>
2018-11-16 11:19:37 +08:00
aaa31bbb1a Fix no-new-privileges test
Update the test to compare the output from different containers.

Signed-off-by: Yiqiao Pu <ypu@redhat.com>
2018-11-16 10:49:24 +08:00
a7122d68de The system test write with ginkgo
The tests can be filter by --focus and --skip to fit different test
target. Also be able to set global options and cmd options by export
it to ENV to fit different test matrix.

Signed-off-by: Yiqiao Pu <ypu@redhat.com>
2018-11-16 10:49:12 +08:00
74bcfc2f96 Separate common used test functions and structs to test/utils
Put common used test functions and structs to a separated package.
So we can use them for more testsuites.

Signed-off-by: Yiqiao Pu <ypu@redhat.com>
2018-11-16 10:49:00 +08:00
dba45a13c0 Add version command to pypodman
pypodman does not currently support the version command.  We want to
have as close to the same functionality between podman and pypodman,
so adding this command.

Also had to fix some validate errors.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2018-11-15 20:15:52 -05:00
236408bbbc Merge pull request #1821 from mheon/bump-0.11.1.1
Bump to v0.11.1.1
2018-11-15 15:42:48 -05:00
02bd5d4443 Bump gitvalidation epoch
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-11-15 15:40:56 -05:00
6593826338 Bump to v0.11.2-dev
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-11-15 15:40:55 -05:00
594495db26 Bump to v0.11.1.1
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
v0.11.1.1
2018-11-15 15:40:49 -05:00
1b52843cfd Merge pull request #1819 from mheon/release_notes_0.11.1.1
Add release notes for 0.11.1.1
2018-11-15 15:37:53 -05:00
286801229a Merge pull request #1820 from TomSweeneyRedHat/dev/tsweeney/storeven1
Vendor in containers/storage
2018-11-15 15:37:38 -05:00
a620f345fa Vendor in containers/storage
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2018-11-15 13:57:03 -05:00
663ed73672 Add release notes for 0.11.1.1
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-11-15 13:48:17 -05:00
0ee56e57df Merge pull request #1818 from EmilienM/issue/1816
Increase pidWaitTimeout to 60s
2018-11-15 10:10:00 -08:00
c3d8328150 Increase pidWaitTimeout to 60s
At scale, it appears that we sometimes hit the 1000ms timeout to create
the PID file when a container is created or executed.
Increasing the value to 60s should help when running a lot of containers
in heavy-loaded environment.

Related #1495
Fixes #1816
Signed-off-by: Emilien Macchi <emilien@redhat.com>
2018-11-15 10:58:27 -05:00
97bded4a52 Merge pull request #1814 from cevich/cirrus_badge
Cirrus: Add master branch testing status badge
2018-11-14 10:09:01 -08:00
1fb3851620 Cirrus: Add master branch testing status badge
Engineers get testing status via their PR's but another round of testing
happens post-merge, without any direct feedback.  Fix this in a small
way, by adding a dynamic status badge on the front-page.  If this
turns red, it means Cirrus-CI testing of the master branch failed
for some reason.

Nearly always it's something harmless, but once and a while, this
catches really nasty problems caused by merge-sequence issues.
Having that feedback on the front page ensures the right people will
eventually get called into action.

Signed-off-by: Chris Evich <cevich@redhat.com>
2018-11-14 10:23:53 -05:00
2b911b0c8a Merge pull request #1812 from giuseppe/rootless-once
rootless: call IsRootless just once
2018-11-14 06:28:27 -08:00
1e3ff69502 rootless: call IsRootless just once
we are calling this function several times, it is worth to store its
result and re-use it.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2018-11-14 10:13:50 +01:00
12f3721c34 Merge pull request #1811 from TomSweeneyRedHat/dev/tsweeney/gov1.10
Bump golang to v1.10 in install.md
2018-11-13 17:47:57 -08:00
41c3530d75 Bump golang to v1.10 in install.md
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2018-11-13 13:40:29 -05:00
8b3fcb374b Cirrus: Add documentation for system-testing
***CIRRUS: REBUILD IMAGES***

Signed-off-by: Chris Evich <cevich@redhat.com>
2018-11-13 13:30:48 -05:00
2cc9b78ab9 Cirrus: Simplify optional system-test script
Previously it was required to call the verify, unit, and integration
scripts in order to build/install dependencies, and libpod.  This
wastes time during the (optional) system-testing, since the
actual unit/integration testing is also happening in parallel.

Consolidate only the distribution-specific build steps into the
system-testing script.  This way, only the required steps are performed
in their respective (parallel) tasks.

Signed-off-by: Chris Evich <cevich@redhat.com>
2018-11-13 13:30:48 -05:00
aa742e9e68 Cirrus: Reveal magic, parallel system-testing
Previously, several magic strings were in place to affect cirrus-ci
operations.  Two were buried within scripts.  One to optionally
execute system-tests within a PR. Another to avoid re-building
cache-images upon every merge.

Move these magic strings out into the open, buy locating their
logic up-front in the ``.cirrus.yml`` file.  This improves
readability and reduces surprise/astonishment at runtime.

Signed-off-by: Chris Evich <cevich@redhat.com>
2018-11-13 13:30:48 -05:00
dd42c1dcff Merge pull request #1804 from cevich/lint_verify_image
Standardized container image for gofmt and lint
2018-11-13 09:03:10 -08:00
50d3199334 Merge pull request #1809 from rhatdan/jedi
Make list of approvers same as reviewers
2018-11-13 06:22:18 -08:00
86d1196f9b Standardized container image for gofmt and lint
Having a standardized image allows uniform application of format and
lint checking across multiple host platforms.  This ensures all
contributors and disparate CI systems to play by a common set of basic
rules.  It also makes it easier to maintain the common rules over-time.

Signed-off-by: Chris Evich <cevich@redhat.com>
2018-11-13 07:55:07 -05:00
fed6b034ae Merge pull request #1807 from giuseppe/vendor-ostree-go
vendor: update ostree-go
2018-11-13 04:53:30 -08:00
6c18a53a6c Make list of approvers same as reviewers
Can't see any reason for a difference here. If you can review, you can approve.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2018-11-13 06:57:03 -05:00
bb6c1cf8d1 libpod should know if the network is disabled
/etc/resolv.conf and /etc/hosts should not be created and mounted when the
network is disabled.

We should not be calling the network setup and cleanup functions when it is
disabled either.

In doing this patch, I found that all of the bind mounts were particular to
Linux along with the generate functions, so I moved them to
container_internal_linux.go

Since we are checking if we are using a network namespace, we need to check
after the network namespaces has been created in the spec.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2018-11-13 06:33:10 -05:00
900436e70f Merge pull request #1805 from rhatdan/rpm
Cleanup podman spec to not show git checkout is dirty
2018-11-13 02:55:36 -08:00
dd6e8cc3a3 vendor: update ostree-go
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2018-11-13 10:34:12 +01:00
6f2ae41211 vendor.conf: fix typo
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2018-11-13 10:33:55 +01:00
e2013b4ff4 Cleanup podman spec to not show git checkout is dirty
Currently we modify the git checkout which ends up showing that the checkout is dirty.  This patch sets the PYTHON_VERSION so that python code will handle
it correctly without having to modify the actual code.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2018-11-12 17:09:01 -05:00
7965716c74 Merge pull request #1803 from QiWang19/issuebuildah1051
Add space between num & unit in images output
2018-11-12 13:33:28 -08:00
b6fabf1d21 Add space between num & unit in images output
Signed-off-by: Qi Wang <qiwan@redhat.com>
2018-11-12 14:06:31 -05:00
a4cc7bca60 Merge pull request #1802 from mheon/troubleshooting_rootless
Update troubleshooting guide to deal with rootless path
2018-11-12 10:34:13 -08:00
51a1b85fb5 Merge pull request #1779 from giuseppe/troubleshoot-unprivileged-ping
troubleshooting.md: add a recipe for rootless ping
2018-11-12 09:57:33 -08:00
8bda62e061 Update troubleshooting guide to deal with rootless path
We had a breaking change to rootless containers' temporary files
directories in Podman 0.11.1. Document a workaround to make the
change no longer working.

Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2018-11-12 12:35:22 -05:00
d2f2c56aaa Merge pull request #1794 from jmtd/patch-1
remove $-prefix from (most) shell examples
2018-11-12 09:34:45 -08:00
87668f10c1 Merge pull request #1799 from xakraz/fixes/doc_containers
docs: Fix duplicated entry for pod-container-unmount
2018-11-12 07:52:05 -08:00
40f8622742 troubleshooting.md: add a recipe for rootless ping
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2018-11-12 13:03:13 +01:00
eb91f82bb2 remove $-prefix from (most) shell examples
For the shell examples related to building and installing podman, remove the
shell prompt indicator character '$'.

This makes copying and pasting lines much easier.

Retain the prompt indicator for the post-install shell examples, since they
(often) mix shell commands and shell command output, so it serves a useful
purpose to distinguish them.

Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
2018-11-12 11:38:57 +00:00
d5375b59aa Merge pull request #1795 from rhatdan/user
Better document rootless containers
2018-11-12 00:17:34 -08:00
c8c174aaca docs: Fix duplicated entry for pod-container-unmount
Signed-off-by: Xavier Krantz <xakraz@gmail.com>
2018-11-11 07:44:41 +01:00
e938345760 Lint: Silence few given goconst lint warnings
While we have these string literals on repeated on multiple places in the
library, I cannot see real tangible benefit extracting these to constants
considering following facts:
 (1) while 'unknown' or 'host' are repeated, they are often times used in
     different context and thus perhaps worth extra const per each use.
 (2) while these string literals repeat, the library is full of string literals
     with special meaning that should be made constants too
 (3) readability would suffer

Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
2018-11-10 10:52:24 +01:00
7457815ba9 Lint: Extract constant unknownPackage
Addressing goconst warning: 3 other occurrence(s) of "Unknown" found

Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
2018-11-10 10:52:24 +01:00
4e75551530 Lint: Tests: add missing assertions
Addressing:
ineffectual assignment to err (ineffassign)

Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
2018-11-10 10:52:24 +01:00