Commit Graph

2520 Commits

Author SHA1 Message Date
OpenShift Merge Robot
cba5791a5d Merge pull request #5233 from QiWang19/login/out-parameter
fix mandatory parameter in login/logout
2020-02-19 15:11:54 +01:00
Valentin Rothberg
0fcaa93573 libpod.conf: clarify label description
Clarify that the label option sets the defaults which can still be
overriden by the CLI.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-02-19 11:04:02 +01:00
OpenShift Merge Robot
c58926e54b Merge pull request #5243 from Akasurde/misc_typo
Misc typo fixes
2020-02-18 21:58:14 +01:00
Qi Wang
4c135017b2 fix mandatory parameter in login/logout
fix #5146
Insted of using a registry as mandatory parameter, this path allows podman to use the first registry from registries.conf.

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-02-18 15:30:49 -05:00
OpenShift Merge Robot
5dacee9395 Merge pull request #5223 from vrothberg/ps-image-id
podman-ps: support image IDs
2020-02-18 16:11:28 +01:00
Abhijeet Kasurde
9419807cef Misc typo fixes
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-18 16:00:36 +05:30
Valentin Rothberg
3c2cc67867 podman-ps: support image IDs
Support printing image IDs via `--format "{{.ImageID}}"`.

Fixes: #5160
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-02-17 15:22:21 +01:00
Allan Jacquet-Cretides
59c91069c0 Update documentation of commit command to show image reference is optional
Following
Commit ba1d1304a6 ("make image reference for commit optional")

Updates usage text used by cobra and markdown document used to generate MAN page.

Fixes: #5145

Signed-off-by: Allan Jacquet-Cretides <allan.jacquet@gmail.com>
2020-02-15 11:11:00 +01:00
OpenShift Merge Robot
0e644933ff Merge pull request #5192 from kolyshkin/man
podman-run(1): fixes
2020-02-14 17:28:51 +01:00
Kir Kolyshkin
3fd9f0c028 podman(1): fixes
I saw some bad formatting when reading "man podman-run" and
proceeded to fix it. I have now opened a can of worms...

This commit tries to fix some of the formatting, wording and
other bugs I came across (unfortunately not all of them).

Can't list every fix that I made here, but in general:
- format lists as such (prepend items with "- ");
- format examples as such (enclose in ```...```);
- format literal values (option names, literal values) as **bold**;
- format man page references as **page**(1).
- format replacements (option values) and file names as _italic_;
- remove some duplicate info (such as what's the default value);
- move option value description to option syntax;
- end sentences with a period.

To test:
```console
$ make docs
$ man ./docs/build/man/podman-run.1 ### check terminal formatting
$ man -Tps ./docs/build/man/podman-run.1 > podman-run.ps
$ ps2pdf podman-run.ps ### optional
$ evince podman-run.pdf ### check printer formatting (or use ps viewr
```

NOTE
 - there is much more to do here;
 - I haven't checked any factual contents, this is about formatting

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
2020-02-13 16:28:31 -08:00
OpenShift Merge Robot
2814995a92 Merge pull request #5115 from QiWang19/images-format
images --format compatible with docker
2020-02-13 11:42:47 +01:00
OpenShift Merge Robot
a65f6b888a Merge pull request #5152 from QiWang19/device-cgroup-rule
support device-cgroup-rule
2020-02-13 02:34:42 +01:00
Qi Wang
d3260738d3 support device-cgroup-rule
fix #4876
Add `--device-cgroup-rule` to podman create and run. This enables to add device rules after the container has been created.

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-02-12 14:30:23 -05:00
OpenShift Merge Robot
e223675625 Merge pull request #5144 from marusak/doc_fixes
[CI:DOCS] podman system service doc fixes
2020-02-12 13:48:56 +01:00
Qi Wang
3afd1b5a7c images --format compatible with docker
This patch lets valid values of --format be compatible with docker. Replace CreatedTime with CreatedAt, Created with CreatedSince.
Keep CreatedTime and Created are valid as hidden options.

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-02-10 10:34:40 -05:00
Matej Marusak
6eac49ed1d doc: Fix examples for 'podman system service'
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2020-02-10 16:26:27 +01:00
Stefan Becker
20cb169874 docs: add workaround for --device with rootless containers (II)
Update documentation for crun >= 0.11.

See 6df930821d

Fixes #4477

Signed-off-by: Stefan Becker <chemobejk@gmail.com>
2020-02-10 11:19:33 +02:00
Matthew Heon
41b735af05 Move podman-service to podman-system-service
Fixes #5108

Signed-off-by: Matthew Heon <mheon@redhat.com>
2020-02-06 13:41:57 -05:00
Matthew Heon
ee5b749e65 Force --all when --filter is passed to podman ps
When we filter, it should be out of all containers, not just
running ones, by default - this is necessary to ensure Docker
compatability.

Fixes #5050

Signed-off-by: Matthew Heon <mheon@redhat.com>
2020-02-04 09:52:25 -05:00
OpenShift Merge Robot
ba1d1304a6 Merge pull request #5028 from baude/commitimage
make image reference for commit optional
2020-01-30 17:10:20 -08:00
OpenShift Merge Robot
fad36345f5 Merge pull request #5024 from rpjday/markdown/asterisks
markdown: fix erroneous asterisk markup for options
2020-01-30 14:44:39 -08:00
Brent Baude
9bbf08de25 make image reference for commit optional
to match docker compat, the image tag should be optional.

Fixes: #5027

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-01-30 09:51:59 -06:00
OpenShift Merge Robot
1729350f66 Merge pull request #4951 from rpjday/docs/unshare
markdown: fix grammar/formatting, standardize on markdown
2020-01-30 06:40:16 -08:00
Robert P. J. Day
0bc96b4829 markdown: fix erroneous asterisk markup for options
Fix option markup in a number of man pages so it renders
properly when viewing online.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-30 06:44:33 -05:00
OpenShift Merge Robot
d8f2333b29 Merge pull request #4984 from baude/pullarchoverride
expose --arch-override option for pull
2020-01-28 11:39:56 -08:00
Robert P. J. Day
8c825cdaae docs: replace '~' with $HOME in markdown as '~' isn't rendered properly
Apparently, a tilde is currently rendered as a single space, making
a mess of command examples that use it, so use $HOME instead.

https://github.com/mattermost/mattermost-server/issues/8228

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-28 12:56:55 -05:00
OpenShift Merge Robot
d07c263106 Merge pull request #4999 from rpjday/docs/network_rst
docs: fix incomplete heading underlining in network.rst
2020-01-28 05:08:37 -08:00
OpenShift Merge Robot
3b574dde6c Merge pull request #4995 from rpjday/docs/podman_stop
docs: add missing hyphen for '-t' option, command '$' prompts
2020-01-28 04:44:15 -08:00
Robert P. J. Day
2460bacbf9 docs: fix incomplete heading underlining in network.rst
Lack of proper underlining generates processing diagnostic.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-28 06:44:07 -05:00
OpenShift Merge Robot
9d30e9f2b6 Merge pull request #4974 from rhatdan/man
Cleanup man pages exit code descriptions
2020-01-28 03:28:18 -08:00
Robert P. J. Day
c38e22de23 docs: add missing hyphen for '-t' option, command '$' prompts
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-28 05:31:52 -05:00
Brent Baude
d42b064c8c expose --arch-override option for pull
We no longer wish to hide the --arch-override from the cli on pulls. we now expose it.  docs updated.  tests already exist.

Fixes: #4849

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-01-27 10:06:39 -06:00
OpenShift Merge Robot
7794fafdad Merge pull request #4982 from rpjday/rpjday/exists_sudo
docs: remove reference to "sudo" in "podman exists" examples
2020-01-27 04:49:58 -08:00
Robert P. J. Day
4aeb25d5f2 docs: add boolean values and defaults to "man podman-history" options
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-26 14:13:54 -05:00
OpenShift Merge Robot
c28af15932 Merge pull request #4979 from rpjday/rpjday/system_prune
docs: fix system-prune markdown; reword for clarity
2020-01-26 10:18:27 -08:00
Robert P. J. Day
bb66d78b2f docs: remove reference to "sudo" in "podman exists" examples
In both of "podman {container,image} exists" man pages, there
are superfluous uses of "sudo" in examples -- get rid of them.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-26 12:43:26 -05:00
Robert P. J. Day
5871446e8d docs: fix system-prune markdown; reword for clarity
In addition to tweaking markdown, reword the explanation of
the "--volumes" option for clarity.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-26 07:46:21 -05:00
Robert P. J. Day
3ff2ea329b docs: clean up "man podman-rm", "man podman-rmi"
Standardize markdown for options and commands, and add leading
dollar signs to emphasize commands being run.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-26 07:16:16 -05:00
OpenShift Merge Robot
d7e99b04b9 Merge pull request #4933 from rpjday/docs/markdown/inspect
markdown: reword 'podman-inspect' to properly explain '--size'
2020-01-26 03:00:31 -08:00
Robert P. J. Day
2e34d06d0f docs: mention that "podman version" prints out Remote API Version
Since "man podman-version" seems to want to list everything printed
about the current version, add a reference to Remote API Version
for completeness.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-26 05:40:41 -05:00
Daniel J Walsh
2557cdb4b2 Cleanup man pages exit code descriptions
The conversion of markdown to man pages is causing "_" to cover entire lines.
This PR cleans this up and fixes some of the english.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-01-26 08:53:52 +01:00
OpenShift Merge Robot
c21445d73d Merge pull request #4926 from TomSweeneyRedHat/dev/tsweeney/fixsystemdf
Fix example format in system df man
2020-01-25 23:35:33 -08:00
Robert P. J. Day
103b5e7807 markdown: fix grammar/formatting, standardize on markdown
While fixing grammar and list formatting issues, standardize on
markdown as follows:

  - commands are marked by '**'
  - files are marked by backquotes
  - list items are marked with leading '-'

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-23 06:59:21 -05:00
Valentin Rothberg
1531509542 seccomp policy: expect profile in config label
Move the seccomp profile from a manifest annotation to a config label.
This way, we can support it for Docker images as well and provide an
easy way to add that data via Dockerfiles.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-01-23 10:06:43 +01:00
TomSweeneyRedHat
71c38e8f2e Fix example format in system df man
Fix the formatting of the examples in the
podman system df man page.

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2020-01-22 16:59:21 -05:00
OpenShift Merge Robot
94b53a2d4a Merge pull request #4929 from rpjday/docs/migrate
markdown: remove erroneous spaces after '**'
2020-01-22 15:40:46 -05:00
OpenShift Merge Robot
c42383f70a Merge pull request #4934 from rpjday/docs/markdown/exec
markdown: fix formatting of commands at bottom of podman-exec
2020-01-22 13:23:40 -05:00
OpenShift Merge Robot
9f146b1b54 Merge pull request #4861 from giuseppe/add-cgroups-disabled-conmon
oci_conmon: do not create a cgroup under systemd
2020-01-22 17:00:48 +01:00
Robert P. J. Day
1e82702ff5 markdown: fix formatting of commands at bottom of podman-exec
Current (lack of) formatting crunches first two lines together.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-22 10:57:16 -05:00
Robert P. J. Day
a78658a11a markdown: reword 'podman-inspect' to properly explain '--size'
Reword the man page to clarify that the '--size' option displays
the container size in addition to the normal output.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
2020-01-22 10:02:06 -05:00