opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-11-29 17:48:05 +08:00
Code Issues Packages Projects Releases Wiki Activity
26,046 Commits 57 Branches 257 Tags
1800b34b51c7c61e650d0a2d2e36eb25e2dcb66d
Commit Graph

198 Commits

Author SHA1 Message Date
Ygal Blum
1800b34b51 Quadlet build - add support for IgnoreFile key 
Resolves: https://github.com/containers/podman/issues/27268

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-10-16 14:02:04 -04:00
openshift-merge-bot[bot]
32d6c54054 Merge pull request #26624 from Odilhao/artifact-quadlet-implementation 
Add artifact quadlet unit type support
 2025-10-13 14:41:25 +00:00
Odilon Sousa
34254cd1d0 Add artifact quadlet unit type support 
RFE: Add artifact quadlet unit type #25778

Signed-off-by: Odilon Sousa <osousa@redhat.com>
 2025-10-10 11:08:33 -03:00
ByoungUk Lee
d1c43e3ae8 Fixed #27120: Pod Quadlet can configure podman pod stop --time 
Signed-off-by: ByoungUk Lee <nimdrak@gmail.com>
 2025-10-08 23:53:14 +09:00
Jan Rodák
98cb7b75d9 quadlet: standardize Convert function signatures 
Remove unused 'name' parameter from ConvertPod and reorder ConvertContainer
parameters to match other Convert functions (unitFile, unitsInfoMap, isUser).

Signed-off-by: Jan Rodák <hony.com@seznam.cz>
 2025-10-06 18:26:47 +02:00
Jan Rodák
09e535fb46 quadlet: remove unused 'name' parameter from ConvertNetwork and ConvertVolume 
The 'name' parameter was unused in both ConvertNetwork and ConvertVolume functions.
Remove the parameter entirely and update all function calls accordingly.

This fixes revive linter warnings:
- pkg/systemd/quadlet/quadlet.go:961:47: unused-parameter: parameter 'name' seems to be unused
- pkg/systemd/quadlet/quadlet.go:1050:45: unused-parameter: parameter 'name' seems to be unused

Signed-off-by: Jan Rodák <hony.com@seznam.cz>
 2025-10-06 14:00:49 +02:00
openshift-merge-bot[bot]
ef584d4d6d Merge pull request #27169 from ygalblum/quadlet-template-dependency 
Quadlet - Support template dependency
 2025-10-03 15:51:31 +00:00
Matt Souza
090304a054 lint: reenable revive unused-parameter check 
Signed-off-by: Matt Souza <medsouz99@gmail.com>
 2025-10-01 10:42:08 -04:00
Ygal Blum
83e65f91a4 Quadlet - Support template dependency 
Add support for Volumes and Networks
Add e2e and system tests

Resolves: https://github.com/containers/podman/issues/25136

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-09-30 13:41:20 -04:00
Paul Holzinger
9e4fad8d06 pkg/systemd/quadletL silence one lint warning 
t.Chdir() is not an exact replacement here

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2025-09-10 16:17:05 +02:00
Paul Holzinger
8631032556 run modernize -fix ./... 
Using golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize

+ some manual cleanup in libpod/lock/shm/shm_lock_test.go as it
  generated an unused variable
+ restored one removed comment

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2025-09-10 16:17:04 +02:00
Ygal Blum
936a01e088 Quadlet build - consider File path that starts with a systemd specifier as absolute 
Fixes https://github.com/containers/podman/issues/26746

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-09-09 13:57:36 -04:00
Jakob Meier
163bdf2df8 quadlet: fix runtime error for invalid Mount value 
If the `Mount` option inside a quadlet is missing the source=... part,
the code today panics with the following message.

```
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
github.com/containers/podman/v5/pkg/systemd/quadlet.handleStorageSource(0xc000140de0?, 0x1d?, {0x0?, 0x1?}, 0x5634e39e233e?, 0x10?)
...
```

This commit checks for the missing source and returns an error to avoid the panic.

Signed-off-by: Jakob Meier <mail@jakobmeier.ch>
 2025-09-04 21:46:01 +02:00
openshift-merge-bot[bot]
428c854be6 Merge pull request #26932 from ogajduse/feature/quadlet-httpproxy-26925 
quadlet: add HttpProxy option for Container sections
 2025-09-01 16:04:15 +00:00
Ondřej Gajdušek
c65fd9a2c2 quadlet: add HttpProxy option for Container sections 
Add support for HttpProxy key in quadlet Container sections to control
proxy environment variable inheritance during image pulls and builds.

- HttpProxy=true enables proxy inheritance (default podman behavior)
- HttpProxy=false disables proxy inheritance
- When omitted, uses podman's default behavior

This addresses the need for declarative proxy configuration in IPv6-only
networks and other scenarios where proxy settings need to be controlled
at the container level without manual workarounds.

Fixes #26925

Signed-off-by: Ondřej Gajdušek <ogajduse@redhat.com>
 2025-09-01 13:45:06 +02:00
Jan Kaluza
a98154a978 Switch common, storage and image to monorepo. 
Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
 2025-09-01 12:33:04 +02:00
Matt Heon
f293c1a179 Initial implementation of podman quadlet commands 
This adds `podman quadlet list`, `podman quadlet install`,
`podman quadlet rm` and `podman quadlet print`.

Signed-off-by: Matt Heon <mheon@redhat.com>
Co-authored-by: flouthoc <flouthoc.git@gmail.com>
Signed-off-by: flouthoc <flouthoc.git@gmail.com>
 2025-07-18 13:57:11 -07:00
Ygal Blum
439448c287 Quadlet - add support for the Policy key for .image files 
Resolves: #26446

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-07-10 13:06:38 -04:00
Ygal Blum
cd807f8ff6 Quadlet - print warning when fail to parse 
Fixes: #26542

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-07-07 14:49:32 -04:00
Evan Miller
31b4efcaec warn instead of error, lift logic to main.go 
Signed-off-by: Evan Miller <miller.evan815@gmail.com>
 2025-07-02 18:23:00 -07:00
Evan Miller
4b1f7bcb9a Quadlet - Error when units define User, Group, or DynamicUser in Service group 
Fixes: #26543

Signed-off-by: Evan Miller <miller.evan815@gmail.com>
 2025-07-02 00:34:46 -07:00
openshift-merge-bot[bot]
72393c1c53 Merge pull request #26522 from ygalblum/quadlet-pod-service-environment 
Quadlet - Do not override existing Environment in Service group for Pod units
 2025-07-01 19:25:06 +00:00
openshift-merge-bot[bot]
43b74b1754 Merge pull request #26322 from NotSoFancyName/issue-26247 
quadlet: handle generate environment params that inherit from host
 2025-06-30 11:44:33 +00:00
Ygal Blum
f1a1948b23 Quadlet - Do not override existing Environment in Service group for Pod units 
Fixes: #26521

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-06-27 09:56:43 -04:00
openshift-merge-bot[bot]
7808625785 Merge pull request #26472 from Luap99/quadlet-nologrus 
quadlet: remove indirect logrus import
 2025-06-19 19:45:24 +00:00
Paul Holzinger
964069326d quadlet: remove indirect logrus import 
Reduces quadlet binary size about 170kb.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2025-06-19 18:47:40 +02:00
nbspsemicolon
5989370c39 pkg/systemd: expose [Pod] ExitPolicy key for pod create --exit-policy 
Add ExitPolicy key to pod quadlets with logic to default to stop.

Docs updated with clarifcation on default value and usage example.

Simple assert added to bats to verify default constraint exists.

Changed argument order in ginkgo basic pod unit test

Signed-off-by: Neil Bailey <nbsp@nbailey.net>
 2025-06-18 15:08:31 -04:00
Volodymyr Pankin
2b6c477884 quadlet: handle generate environment params that inherit from host 
Fixes: #26247

Signed-off-by: Volodymyr Pankin <volopank@gmail.com>
 2025-06-10 20:50:13 +02:00
Hiếu Lê
18ecd2046b quadlet: generate RequiresMountsFor for Type=bind volumes 
This makes sure that the volume source is available before the volume is
created.

Fixes: https://github.com/containers/podman/issues/26125

Signed-off-by: Hiếu Lê <leorize+oss@disroot.org>
 2025-06-05 18:22:28 -05:00
Paul Holzinger
a0f7db44e8 quadlet: add InterfaceName option to network unit 
I noticed this was missing, its a simple 1 to 1 mapping to
--interface-name.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2025-06-04 16:46:39 +02:00
Ygal Blum
09d9d3e26b Revert "Quadlet - fix pod name to depend on the name of the generate service" 
This reverts commit 4f38c2fea2.

Fixes: #26105
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-05-12 09:33:16 -04:00
Ygal Blum
4f38c2fea2 Quadlet - fix pod name to depend on the name of the generate service 
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-05-06 12:02:01 -04:00
Ygal Blum
9b2fb40ab8 Quadlet - remove the usage of cid and podid for container and pod files 
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-04-30 07:59:15 -04:00
Ygal Blum
3f56de0199 Quadlet - use helper function to initialize service struct 
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-04-28 12:54:56 -04:00
Ygal Blum
633f727f2d Quadlet - use helper function for handling key=val type keys 
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-04-24 14:15:39 -04:00
Robin Heinemeier
802fc15b1e Add Label to quadlet pod 
Signed-off-by: Robin Heinemeier <sunnerlp@gmail.com>
 2025-04-24 13:37:42 +00:00
openshift-merge-bot[bot]
5372c15bf8 Merge pull request #25892 from Regis-Caelum/quadlet-pod-hostname 
Add HostName to quadlet pod
 2025-04-22 12:52:04 +00:00
Inshal Khan
4ba8cde41d Add HostName to quadlet pod 
update docs for hostname

Signed-off-by: Inshal Khan <kziaul123@gmail.com>
 2025-04-19 08:51:45 +05:30
Ygal Blum
6ac0a28564 Quadlet - support additional systemd unit relationship keys 
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-04-17 14:51:24 -04:00
openshift-merge-bot[bot]
17f3aed4fd Merge pull request #25899 from ygalblum/quadlet-unit-deps 
Quadlet - translate dependencies on other quadlet units
 2025-04-16 21:03:52 +00:00
Ygal Blum
e498c6526b Quadlet - translate dependencies on other quadlet units 
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-04-16 15:29:42 -04:00
openshift-merge-bot[bot]
09c2546b27 Merge pull request #25844 from ygalblum/quadlet-network-delete 
Quadlet - allow deleting the network when stopping the service
 2025-04-14 17:57:45 +00:00
Ygal Blum
0d4a148ee6 Quadlet - allow deleting the network when stopping the service 
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-04-10 10:34:16 -04:00
Ygal Blum
fe107ff0ce Quadlet - Add support for adding ExecReload command 
Add tests
Update man page

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-04-09 14:40:41 -04:00
Kir Kolyshkin
1739b7170e pkg/systemd/quadlet: rm splitPorts 
Usage of splitPorts was removed by commit abc4cfb04 ("quadlet: allow
variables in PublishPort") but the function remained, as well as its
tests.

Drop those.

Found by running golangci-lint with --tests=false option.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-03-31 12:27:55 -07:00
Kir Kolyshkin
f4f2580b0d ci: remove stylecheck linter 
It is to be merged into staticcheck linter in golangci-lint v2.0.0.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-03-31 12:27:55 -07:00
Kir Kolyshkin
0dddc5e3c0 Apply De Morgan's law 
This fixes a bunch of "QF1001: could apply De Morgan's law" warnings
from staticcheck linter.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-03-31 12:27:55 -07:00
Jan Kaluza
08a1c6d91e Add support for Retry= and RetryDelay= to Podman Quadlet. 
This commit adds new Retry= and RetryDelay= options
to quadlet.go which result in --retry and --retry-delay
usage in podman run, image and build commands.

This allows configuring the retry logic in the systemd
files.

Fixes: #25109

Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
 2025-03-26 09:01:28 +01:00
Ygal Blum
02658bc4cc Quadlet - Propagate warnings and print errors and warnings as they occur 
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
 2025-03-10 11:51:32 -04:00
Ben Boeckel
543be25ef3 quadlet: support Memory= in [Container] sections 
Maps to the `--memory=` flag.

Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
 2025-02-17 17:29:15 +01:00