They require many manual steps and are actively misleading even. The
size reported via this script is before unused symbols get trimmed by
the compiler so the package binary size here is meaningless.
As such I think they do not add any value over the script added in
contrib/dependencies so just remove them. This also gets rid of the top
level dependencies directory which serves no purpose and I think the new
scrip is better under contrib/.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
As part of my debloat activity I wrote a small script that makes use of
goda[1] to check our imports and what we can likely trim to reduce the
binary size.
I also added a readme to document what I did basically. This should help
anyone doing this work in the future again.
[1] github.com/loov/goda
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Right now, only log-level=info, so not shown by default. We can
continue to up this in subsequent releases to convince folks of
the urgency of switching.
Resolves https://issues.redhat.com/browse/RUN-3343
Signed-off-by: Matt Heon <mheon@redhat.com>
There is a rather surprising bug in the current test checkout logic. The
go.mod version parsing never actually consider a go.mod replace for
buildah and always read the main version.
This meant a buildah replace actually is testing the old version with
the new code and that means the new tests are not run leading people in
false belive when testing a buildah vendor that it worked. But then
later it fails when doing the proper update without replace.
To fix this first use go list to parse go.mod which is more robust. Then
first check if there is a replace and then use that repo/version
instead.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Added log_path variable in containers/common, User sets default log path in containers.conf under the `[containers]` section.
The directory has to exist beforehand. Container logs go under this directory, sub-directories named with the container id
and inside the sub-directory a ctr.log file will be created where the container logs for the corresponding container will go.
This path can be overridden by using the `--log-opt` flag.
Signed-off-by: Joshua Arrevillaga <2004jarrevillaga@gmail.com>
manpages
Signed-off-by: mohitjain1911 <mohitjain19113@gmail.com>
Manpages: Added --filter examples to podman-stop.1.md.in
Signed-off-by: mohitjain1911 <mohitjain19113@gmail.com>
Manpages: Added examples for --filter flag for 'podman start' command in podman-start.1.md.in
Signed-off-by: mohitjain1911 <mohitjain19113@gmail.com>
Manpages: Added examples for --filter flag for 'podman rm' command in podman-rm.1.md.in
Signed-off-by: mohitjain1911 <mohitjain19113@gmail.com>
Manpages: Added examples for --filter flag for 'podman restart' command in podman-restart.1.md.in
Signed-off-by: mohitjain1911 <mohitjain19113@gmail.com>
Manpages: Added examples for --filter flag for 'podman pod ps' command in podman-pod-ps.1.md.in
Signed-off-by: mohitjain1911 <mohitjain19113@gmail.com>
Manpages: Added examples for --filter flag for 'podman system prune' command in podman-system-prune.1.md
Signed-off-by: mohitjain1911 <mohitjain19113@gmail.com>
This patch adds a new --tls-verify flag to the `podman machine init`
sub command which matches many of our other commands. This allows the
user to optionally control whether TLS verification is enabled or
disabled for download of the machine image.
The default remains to leave the TLS verification decision to the
backend library which defaults to enabling it, this patch just
allows the user to explicitly set it on the CLI.
Fixes: #26517
Signed-off-by: Lewis Roy <lewis@redhat.com>
The machine images should contain a new enough podman on the server side
to support this so the skips can be removed.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
podman-next failure notifications are mostly if not totally ignored so
there's no point keeping them.
While these notifications ideally shouldn't be ignored, some builds on
podman-next frequently fail because of older toolchain and end up
causing a lot of noise.
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
I ran `make help` and found it confusing that `binaries` is listed three times:
```console
Target: Description:
-------------- --------------------
binaries Build podman and podman-remote binaries
binaries Build podman, podman-remote and rootlessport binaries quadlet
binaries Build podman-remote (client) only binaries
clean-binaries Remove platform/architecture specific binary files
clean Clean all make artifacts
docs Generate documentation
help (Default) Print listing of key targets with their descriptions
install.tools Install needed tools
install Install binaries to system locations
local-cross Cross compile podman binary for multiple architectures
podman-mac-helper Build podman-mac-helper for macOS
podman-remote-release-%.zip Build podman-remote for %=$GOOS_$GOARCH, and docs. into an installation zip.
rpm-install Install rpm packages
rpm Build rpm packages
test Run unit, integration, and system tests.
validatepr Go Format and lint, which all code changes must pass
```
So I'm proposing a way to differentiate btween them.
Signed-off-by: Osama Albahrani <54853250+osalbahr@users.noreply.github.com>
Add comprehensive examples showing shared resource limits and volume mounts
for all containers in a pod. This addresses the missing examples for resource limits and mounts in the
podman pod create manpage.
Signed-off-by: shiavm006 <shivammittal42006@gmail.com>
Since compat version 1.43 the VirtualSize field in the
GET /images/{name}/json, GET /images/json, and
GET /system/df responses is deprecated and will no
longer be included in API v1.44. Use the Size field
instead, which contains the same information.
Signed-off-by: Nicola Sella <nsella@redhat.com>
Remove the "Experimental" stanza from the Podman Artifact commands
in time for Podman v5.6 and RHEL 9.7/10.1
Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
- Add specific check for empty device modes in ParseDevice function
- Change error message from 'invalid device mode: ' to 'empty device mode in device specification: <device>'
- Include full device specification in error message for better context
- Add test cases for empty device mode scenarios
- Resolves issue where '/dev/fuse::' provided unhelpful error message
Fixes#26629
Signed-off-by: Devashish08 <devashish.cs025@gmail.com>
