25696 Commits

Author SHA1 Message Date
719ea83555 Merge pull request #26454 from TomSweeneyRedHat/dev/tsweeney/tweaked_Governance
[CI:DOCS] Tweak Governance slightly
2025-06-23 18:59:27 +00:00
98876454cb Refactor volume import to support the remote client
As with `volume export`, this was coded up exclusively in cmd/
instead of in libpod. Move it into Libpod, add a REST endpoint,
add bindings, and now everything talks using the ContainerEngine
wiring.

Also similar to `volume export` this also makes things work much
better with volumes that require mounting - we can now guarantee
they're actually mounted, instead of just hoping.

Includes some refactoring of `volume export` as well, to simplify
its implementation and ensure both Import and Export work with
readers/writers, as opposed to just files.

Fixes #26409

Signed-off-by: Matt Heon <mheon@redhat.com>
2025-06-23 13:42:22 -04:00
67fa077a5c update image_fix -> automation_images#407
skip test duo to rawhide know issues

Signed-off-by: Tim Zhou <tizhou@redhat.com>
2025-06-23 13:24:58 -04:00
5ab4328318 Podman pull - add policy flag
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2025-06-23 11:28:39 -04:00
72e8c82c37 Merge pull request #26490 from Luap99/pasta-testfix
test/e2e: fix "with unsafe hostPath subpaths" test
2025-06-23 15:06:37 +00:00
b433eb5e6d Merge pull request #26471 from Luap99/refresh-panic
fix panic on state refresh
2025-06-23 15:03:43 +00:00
14a99b3d65 Merge pull request #26476 from sushmitha37/add-machine-start-examples
update podman-machine-start with examples for --no-info and --quiet
2025-06-23 13:14:19 +00:00
17601aa913 Pod YAML: Add support for lifecycle.stopSignal
The field allows users to specify a custom stop signal (e.g., SIGUSR1) per container.
If defined, it overrides the default stop signal (SIGTERM) or that defined in the image metadata.

Fixes: #25389

Signed-off-by: Arthur Wu <lion811004@gmail.com>
2025-06-23 08:23:31 -04:00
726b506acc machine init: fix tls check
Ensure we verify the TLS connection when pulling the OCI image.

Fixes: CVE-2025-6032

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-23 14:12:55 +02:00
ca1c4388b3 update podman-machine-start with examples for --no-info and --quiet
Fixes: #26375

Signed-off-by: sushmitha37 <sushu52581@gmail.com>
2025-06-23 16:10:26 +05:30
01fb3aaae4 test/e2e: fix "with unsafe hostPath subpaths" test
A recent pasta update changed the selinux rules and we now run pasta
under pasta_t and no longer the container_runtime_t type. The pasta type
has much stricter type rules on what the file we hand it must be
labelled. This test tries to mount the runroot which gets relabeled with
the container_file_t type but that means pasta can no longer access its
pid file we give it. To fix this test here simply mount a subdir.

see #26473

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-23 11:54:02 +02:00
7808625785 Merge pull request #26472 from Luap99/quadlet-nologrus
quadlet: remove indirect logrus import
2025-06-19 19:45:24 +00:00
617cdc4b36 Merge pull request #26466 from nbspsemicolon/quadlet-pod-exitpolicy
pkg/systemd: expose [Pod] ExitPolicy key for pod create --exit-policy
2025-06-19 19:01:13 +00:00
964069326d quadlet: remove indirect logrus import
Reduces quadlet binary size about 170kb.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-19 18:47:40 +02:00
5c89b64441 Merge pull request #26463 from shu-kitamura/example_generate-spec
docs: add three examples to podman-generate-spec man page
2025-06-19 11:59:16 +00:00
fa67681601 docs: add three examples to podman-generate-spec man page
This patch adds three examples to the podman-generate-spec.1 man page:

- Example of executed without any options
- Example of executed with the `--compact` option
- Example of executed with the `--filename` option

Fixes: #26377

Signed-off-by: shu-kitamura <shusei3316@yahoo.co.jp>
2025-06-19 20:17:08 +09:00
e4c810a8f1 fix panic on state refresh
In order to use parallel.Enqueue() it is required to call
parallel.SetMaxThreads() first. However in our main call we have been
doing this after we setup the initial runtime so just move this up.
And while at it move up the cpu and memory profile setup as well so we
can capture the earlier parts as well.

This was most likely introduced by commit 46d874aa52 ("Refactor graph
traversal & use for pod stop") which started using parallel.Enqueue() in
removePod() which then can get called from refresh() when a container
has autoremoval configured.

I tried many hard resets in VMs to reproduce but was unable to do so.
I always got "retrieving temporary directory for container xxx: no such
container" erros instead and it failed to autoremove but no panics.
Besides that many times c/storage was corrupted which made the image I
used unusable and it had to be deleted which is concerning in itself.

Fixes #26469

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-19 12:46:23 +02:00
5989370c39 pkg/systemd: expose [Pod] ExitPolicy key for pod create --exit-policy
Add ExitPolicy key to pod quadlets with logic to default to stop.

Docs updated with clarifcation on default value and usage example.

Simple assert added to bats to verify default constraint exists.

Changed argument order in ginkgo basic pod unit test

Signed-off-by: Neil Bailey <nbsp@nbailey.net>
2025-06-18 15:08:31 -04:00
dfd205fa24 Merge pull request #26459 from giuseppe/add-volume-uid-gid
volumes: add new --uid and --gid option
2025-06-18 14:49:51 +00:00
1f9893817b volumes: add new --uid and --gid option
they allow to override the owner of the volume.  Differently from
-o=uid= and -o=gid= they are not passed down to the mount operation.

Closes: https://issues.redhat.com/browse/RHEL-76452

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2025-06-18 15:33:09 +02:00
70435a0fe8 Merge pull request #26460 from shu-kitamura/example_secret-rm-ingnore
docs: add an example to podman-secret-rm man page
2025-06-18 13:08:58 +00:00
d79d596bce docs: add an example to podman-secret-rm man page
This patch adds an example of using the `--ingore` option to the podman-secret-rm.1 man page.

Fixes: #26361

Signed-off-by: shu-kitamura <shusei3316@yahoo.co.jp>
2025-06-18 21:10:17 +09:00
9a0a13d2a2 Merge pull request #26452 from Luap99/cleanup
repo cleanup: remove unused files
2025-06-18 11:34:34 +00:00
8f9f2ac104 Merge pull request #26457 from containers/renovate/pytest-8.x
chore(deps): update dependency pytest to v8.4.1
2025-06-18 10:06:32 +00:00
a218dfa2fd chore(deps): update dependency pytest to v8.4.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-06-18 08:48:28 +00:00
d7f980b719 [CI:DOCS] Tweak Governace slightly
When I worked up changes to Buildah's Governance, I found
that Podman's version was missing a few links, and there were
a few minor grammatical tweaks needed.

This addresses those.

For reference, Buildah's Governance Update PR: https://github.com/containers/buildah/pull/6124

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2025-06-17 16:21:24 -04:00
a93b63c4ad remove .github/workflows/pr-title.yml
This is not used and AFAICT has not trigger any actions for a very long
time I guess:
https://github.com/containers/podman/actions/workflows/pr-title.yml

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-17 18:43:24 +02:00
0439167943 remove hack/install_catatonit.sh
This was not updated to the latest versions and CI and basically any
user should get in from their distro repos.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-17 18:35:28 +02:00
bf7c9a1536 Makefile: remove some old files from clean target
These have not been build or used for a very long time so they can be
dropped IMO.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-17 18:31:10 +02:00
8cfe7bb003 remove cni/
We no longer support CNI upstream and this default config file has not
been nedded for years since we started to generate our own default file
internally. And since 4.0.0 the default config file only exist in the
bianry and not on disk so this should not be installed by anyone even if
they still happen to use CNI.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-17 18:22:01 +02:00
6623ab8d17 remove pkg/timetype
This package is no longer used. It was moved to c/common in
659c178c2c

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-17 18:16:24 +02:00
5d88999447 remove contrib/modules-load.d
We used this to load the iptables module, since f41 we use nftables by
default which does not need this at all so drop the module load file.

If some distros default still to the legacy iptables they can manually
add the moduled load file back.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-17 18:11:06 +02:00
241f2d7928 remove contrib/snapcraft
AFAICT we never published a snap podman package and this here has never
been updated so remove it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-17 18:04:16 +02:00
4582c3413f remove contrib/script/size.sh
This script does not bring accurate results. For nice dependency
analysis I can recommend goda:

https://github.com/loov/goda

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-17 18:01:51 +02:00
605b1f7386 remove contrib/remote/containers.conf
The config file is installed in the remote zip as an example but the
content in there is not being updated and no longer really the way to do
things. With podman 5.0 we have a proper system connection file and
people in general should just use the system connection commands.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-17 17:59:06 +02:00
e9aad3d40d remove contrib/dependabot-dance
This script was used when dependabot could not deal with vendoring, we
long since moved to renovate which handles it fine with manual steps so
remove this script.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-17 17:55:35 +02:00
14b1ee5837 remove contrib/dependencies.txt
This list is not up to date, a full list can be found in the
rpm/podman.spec file.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-17 17:54:52 +02:00
febb667865 remove contrib/containers-common
It doesn't seem to be used anywhere and is not maintained. An up to date
specfile is found in the c/common repo.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-17 17:51:48 +02:00
20d5b78a79 Merge pull request #26442 from shu-kitamura/example_network-rm-time
docs: add an example to podman-network-rm man page
2025-06-17 13:32:02 +00:00
474740fe2e Merge pull request #26427 from b3n4kh/issue-26349-force-flag-docs
Issue 26349 force flag docs
2025-06-17 11:13:13 +00:00
4ec7d35cbb Removed the 'Deleted: ' prefix from each example
Signed-off-by: shu-kitamura <shusei3316@yahoo.co.jp>
2025-06-17 19:00:44 +09:00
6b996445bc add more exmples applying current style for each page
Signed-off-by: Benjamin Akhras <b@akhras.at>
2025-06-16 19:52:36 +02:00
f235d47e1d Merge pull request #26308 from kolyshkin/blkdev
podman-update: fix block device handling
2025-06-16 14:46:05 +00:00
15d8b5b2fb docs: add an example to podman-network-rm man page
This patch adds an example of using the --time option to the podman-network-rm.1 man page.

Fixes: #26373
Signed-off-by: shu-kitamura <shusei3316@yahoo.co.jp>
2025-06-16 23:31:59 +09:00
547de9296a Merge pull request #26407 from shu-kitamura/example_mac-address
Manpages: podman network connect missing example with --mac-address option
2025-06-16 14:02:57 +00:00
233cae8f61 Merge pull request #26430 from Luap99/artifact-mount-name
artifact mount: improve single file behavior and add name option to specify a custom container name
2025-06-16 13:51:43 +00:00
38b52e380c Merge pull request #26435 from ArthurWuTW/26359
docs: add examples to podman-system-migrate man page
2025-06-16 09:28:22 +00:00
c294f82e46 Merge pull request #26436 from ninja-quokka/add_ST1005
[CI] Correct ST1005 staticcheck lint rule
2025-06-16 09:16:48 +00:00
139d3fc82b [CI] Correct ST1005 staticcheck lint rule
This rule was incorrectly disabled in #26400

You can see here [1] adding "-" disables a rule and ST1005 is enabled by
default.

[1] https://golangci-lint.run/usage/linters/#staticcheck

Signed-off-by: Lewis Roy <lewis@redhat.com>
2025-06-15 21:50:56 +10:00
6510d81f69 docs: add examples to podman-system-migrate man page
This patch adds two usage examples to the podman-system-migrate.1 man page:
- Normal invocation, with no expected output
- Migration to a new OCI runtime (e.g., from crun to runc)

Fixes: #26359
Signed-off-by: Arthur Wu <lion811004@gmail.com>
2025-06-15 01:48:21 -04:00