opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-26 04:46:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

test/e2e: do not use /tmp for podman commands

Browse Source 
Using the OS tempdir here is not good. This defaults to /tmp which means
the inital podman test setup uses these paths:
`--root /tmp/root --runroot /tmp/runroot and --tmpdir /tmp`

Thus we create many files directly under /tmp. Also they were never
removed thus leaked out. When running as root and then later as rooltess
this would fail to permission problems.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This commit is contained in:
Paul Holzinger
2023-07-04 15:37:36 +02:00
parent db7cb1dbfc
commit ff77900387
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
test/e2e/common_test.go
View File

@ -137,7 +137,7 @@ var _ = SynchronizedBeforeSuite(func() []byte {
// Cache images
cwd, _ := os.Getwd()
INTEGRATION_ROOT = filepath.Join(cwd, "../../")
podman := PodmanTestSetup(os.TempDir())
podman := PodmanTestSetup(GinkgoT().TempDir())
// Pull cirros but don't put it into the cache
pullImages := []string{CIRROS_IMAGE, fedoraToolbox, volumeTest}
@ -180,6 +180,9 @@ var _ = SynchronizedBeforeSuite(func() []byte {
podman.StopRemoteService()
}
// remove temporary podman files, images are now cached in ImageCacheDir
podman.removeCache(podman.TempDir)
return []byte(path)
}, func(data []byte) {
cwd, _ := os.Getwd()