From f928cf54aa17790d2a96d980d1c9f0753f0e5326 Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Wed, 8 Mar 2023 13:45:22 +0100 Subject: [PATCH] pasta: Re-enable "Local forwarder, IPv4" test, accept NXDOMAIN as response This case is fixed by passt commit bad252687271 ("conf, udp: Allow any loopback address to be used as resolver") and the fix is now available in packages included by the CI images. Note that, depending on the resolver on the host, we might get 1.0.0.127.in-addr.arpa resolved to localhost, or simply NXDOMAIN for it: accept a failure on the nslookup command, as long as we have a response for 1.0.0.127.in-addr.arpa in the output. If we have any response, that means we could talk to the resolver. Signed-off-by: Stefano Brivio --- test/system/505-networking-pasta.bats | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/test/system/505-networking-pasta.bats b/test/system/505-networking-pasta.bats index d22e6d66e5..032c9b0b89 100644 --- a/test/system/505-networking-pasta.bats +++ b/test/system/505-networking-pasta.bats @@ -319,7 +319,7 @@ function teardown() { @test "podman networking with pasta(1) - External resolver, IPv4" { skip_if_no_ipv4 "IPv4 not routable on the host" - run_podman run --net=pasta $IMAGE nslookup 127.0.0.1 || : + run_podman '?' run --net=pasta $IMAGE nslookup 127.0.0.1 assert "$output" =~ "1.0.0.127.in-addr.arpa" \ "127.0.0.1 not resolved" @@ -335,14 +335,12 @@ function teardown() { } @test "podman networking with pasta(1) - Local forwarder, IPv4" { - skip "FIXME: #17074: some pasta dns problem" skip_if_no_ipv4 "IPv4 not routable on the host" run_podman run --dns 198.51.100.1 \ - --net=pasta:--dns-forward,198.51.100.1 $IMAGE nslookup 127.0.0.1 + --net=pasta:--dns-forward,198.51.100.1 $IMAGE nslookup 127.0.0.1 || : - assert "$output" =~ "1.0.0.127.in-addr.arpa" \ - "127.0.0.1 not resolved to 1.0.0.127.in-addr.arpa" + assert "$output" =~ "1.0.0.127.in-addr.arpa" "No answer from resolver" } @test "podman networking with pasta(1) - Local forwarder, IPv6" {