Merge pull request #14470 from shanesmith/machine-force-remove-doesnt-stop

Stop machine before force removing files
This commit is contained in:
OpenShift Merge Robot
2022-06-03 04:29:02 -04:00
committed by GitHub

View File

@ -831,9 +831,15 @@ func (v *MachineVM) Remove(_ string, opts machine.RemoveOptions) (string, func()
if err != nil { if err != nil {
return "", nil, err return "", nil, err
} }
if state == machine.Running && !opts.Force { if state == machine.Running {
if !opts.Force {
return "", nil, errors.Errorf("running vm %q cannot be destroyed", v.Name) return "", nil, errors.Errorf("running vm %q cannot be destroyed", v.Name)
} }
err := v.Stop(v.Name, machine.StopOptions{})
if err != nil {
return "", nil, err
}
}
// Collect all the files that need to be destroyed // Collect all the files that need to be destroyed
if !opts.SaveKeys { if !opts.SaveKeys {