Merge pull request #11388 from Luap99/stop-cleanup

podman stop always cleanup
This commit is contained in:
OpenShift Merge Robot
2021-09-01 10:04:38 -04:00
committed by GitHub

View File

@ -173,13 +173,17 @@ func (ic *ContainerEngine) ContainerStop(ctx context.Context, namesOrIds []strin
return err return err
} }
} }
if c.AutoRemove() { err = c.Cleanup(ctx)
// Issue #7384: if the container is configured for if err != nil {
// auto-removal, it might already have been removed at // Issue #7384 and #11384: If the container is configured for
// this point. // auto-removal, it might already have been removed at this point.
return nil // We still need to to cleanup since we do not know if the other cleanup process is successful
if c.AutoRemove() && (errors.Is(err, define.ErrNoSuchCtr) || errors.Is(err, define.ErrCtrRemoved)) {
return nil
}
return err
} }
return c.Cleanup(ctx) return nil
}) })
if err != nil { if err != nil {
return nil, err return nil, err