opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-07-04 01:48:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

golangci-lint: install to ./bin

Browse Source 
Install golangci-lint to `./bin` instead of `$GOBIN`.  The latter may be
shared with other projects who require a different version.  Having a
shared version of golangci-lint is a reoccurring source of red herrings
on my work station, so I think it's time to split them.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
This commit is contained in:
Valentin Rothberg
2021-01-17 17:07:04 +01:00
parent 341c4b1fd9
commit f38b7f48cc
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
hack/golangci-lint.sh
View File

@ -21,5 +21,5 @@ for i in tunnel abi; do
echo Running golangci-lint for "$i" echo Running golangci-lint for "$i"
echo Build Tags "$i": ${BUILD_TAGS[$i]} echo Build Tags "$i": ${BUILD_TAGS[$i]}
echo Skipped directories "$i": ${SKIP_DIRS[$i]} echo Skipped directories "$i": ${SKIP_DIRS[$i]}
golangci-lint run --build-tags=${BUILD_TAGS[$i]} --skip-dirs=${SKIP_DIRS[$i]} "$@" ./bin/golangci-lint run --build-tags=${BUILD_TAGS[$i]} --skip-dirs=${SKIP_DIRS[$i]} "$@"
done done

6
hack/install_golangci.sh
View File

@ -7,10 +7,10 @@ die() { echo "${1:-No error message given} (from $(basename $0))"; exit 1; }
[ -n "$VERSION" ] || die "\$VERSION is empty or undefined" [ -n "$VERSION" ] || die "\$VERSION is empty or undefined"
[ -n "$GOBIN" ] || die "\$GOBIN is empty or undefined" [ -n "$GOBIN" ] || die "\$GOBIN is empty or undefined"
BIN="$GOBIN/golangci-lint" BIN="./bin/golangci-lint"
if [ ! -x "$BIN" ]; then if [ ! -x "$BIN" ]; then
echo "Installing golangci-lint v$VERSION into $GOBIN" echo "Installing golangci-lint v$VERSION into $BIN"
curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $GOBIN v$VERSION curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b ./bin v$VERSION
else else
# Prints its own file name as part of --version output # Prints its own file name as part of --version output
echo "Using existing $(dirname $BIN)/$($BIN --version)" echo "Using existing $(dirname $BIN)/$($BIN --version)"