Cleanup error reporting

The error message reported is overlay complicated and the added test does not
really help the user.

Currently the error looks like:

podman run -p 80:80 fedora echo hello
Error: failed to expose ports via rootlessport: "cannot expose privileged port 80, you might need to add "net.ipv4.ip_unprivileged_port_start=0" (currently 1024) to /etc/sysctl.conf, or choose a larger port number (>= 1024): listen tcp 0.0.0.0:80: bind: permission denied\n"

After this change

./bin/podman run -p 80:80 fedora echo hello
Error: cannot expose privileged port 80, you might need to add "net.ipv4.ip_unprivileged_port_start=0" (currently 1024) to /etc/sysctl.conf, or choose a larger port number (>= 1024): listen tcp 0.0.0.0:80: bind: permission denied

Control chars have been eliminated.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
This commit is contained in:
Daniel J Walsh
2020-11-11 07:57:04 -05:00
parent ea75312895
commit f3648b4ae8

View File

@ -556,7 +556,7 @@ func (r *Runtime) setupRootlessPortMappingViaRLK(ctr *Container, netnsPath strin
if stdoutStr != "" { if stdoutStr != "" {
// err contains full debug log and too verbose, so return stdoutStr // err contains full debug log and too verbose, so return stdoutStr
logrus.Debug(err) logrus.Debug(err)
return errors.Errorf("failed to expose ports via rootlessport: %q", stdoutStr) return errors.Errorf("rootlessport " + strings.TrimSuffix(stdoutStr, "\n"))
} }
return err return err
} }