opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-20 00:51:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

rootless v2 cannot collect network stats

Browse Source 
network statistics cannot be collected for rootless network devices with
the current implementation.  for now, we return nil so that stats will
at least for users.

Fixes:#4268

Signed-off-by: baude <bbaude@redhat.com>
This commit is contained in:
baude
2019-10-15 14:00:18 -05:00
parent 5f72e6ef2e
commit f10f9bc58f
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
docs/podman-stats.1.md
View File

@ -15,6 +15,9 @@ Note: Podman stats will not work in rootless environments that use CGroups V1.
Podman stats relies on CGroup information for statistics, and CGroup v1 is not Podman stats relies on CGroup information for statistics, and CGroup v1 is not
supported for rootless use cases. supported for rootless use cases.
Note: Rootless environments that use CGroups V2 are not able to report statistics
about their networking usage.
## OPTIONS ## OPTIONS
**--all**, **-a** **--all**, **-a**

6
libpod/networking_linux.go
View File

@ -462,6 +462,12 @@ func getContainerNetNS(ctr *Container) (string, error) {
func getContainerNetIO(ctr *Container) (*netlink.LinkStatistics, error) { func getContainerNetIO(ctr *Container) (*netlink.LinkStatistics, error) {
var netStats *netlink.LinkStatistics var netStats *netlink.LinkStatistics
// rootless v2 cannot seem to resolve its network connection to
// collect statistics. For now, we allow stats to at least run
// by returning nil
if rootless.IsRootless() {
return netStats, nil
}
netNSPath, netPathErr := getContainerNetNS(ctr) netNSPath, netPathErr := getContainerNetNS(ctr)
if netPathErr != nil { if netPathErr != nil {
return nil, netPathErr return nil, netPathErr