opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-07-04 18:27:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

libpod: race in WaitForConditionWithInterval()

Browse Source 
There are multiple concurrent goroutinces which produce result and they
race agains each other, while producing different results.

This commit addresses at least a part of the problem - producing
different results for competing "sources".

Fixes: #25479

Signed-off-by: Yuri Timenkov <yuri@timenkov.pro>
This commit is contained in:
Yuri Timenkov
2025-03-06 12:40:43 +00:00
parent d0efd0e278
commit eed5f9ee4a
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libpod/container_api.go
View File

@ -771,6 +771,12 @@ func (c *Container) WaitForConditionWithInterval(ctx context.Context, waitTimeou
// This allows callers to actually wait for the ctr to be removed.
if wantedStates[define.ContainerStateRemoving] &&
(errors.Is(err, define.ErrNoSuchCtr) || errors.Is(err, define.ErrCtrRemoved)) {
// check if the exit code was recorded in the db to return it
exitCode, err := c.runtime.state.GetContainerExitCode(c.ID())
if err == nil {
trySend(exitCode, nil)
}
trySend(-1, nil)
return
}