first pass of corrections for golangci-lint

Signed-off-by: baude <bbaude@redhat.com>
This commit is contained in:
baude
2019-07-08 13:20:17 -05:00
parent 81e722d086
commit e053e0e05e
105 changed files with 456 additions and 406 deletions

View File

@@ -21,6 +21,7 @@ package firewall
import (
"fmt"
"github.com/sirupsen/logrus"
"net"
"github.com/coreos/go-iptables/iptables"
@@ -53,7 +54,9 @@ func generateFilterRule(privChainName string) []string {
func cleanupRules(ipt *iptables.IPTables, privChainName string, rules [][]string) {
for _, rule := range rules {
ipt.Delete("filter", privChainName, rule...)
if err := ipt.Delete("filter", privChainName, rule...); err != nil {
logrus.Errorf("failed to delete iptables rule %s", privChainName)
}
}
}
@@ -185,7 +188,9 @@ func (ib *iptablesBackend) Add(conf *FirewallNetConf) error {
func (ib *iptablesBackend) Del(conf *FirewallNetConf) error {
for proto, ipt := range ib.protos {
ib.delRules(conf, ipt, proto)
if err := ib.delRules(conf, ipt, proto); err != nil {
logrus.Errorf("failed to delete iptables backend rule %s", conf.IptablesAdminChainName)
}
}
return nil
}