Correctly report errors on unmounting SHM

When we fail to remove a container's SHM, that's an error, and we
need to report it as such. This may be part of our lingering
storage woes.

Also, remove MNT_DETACH. It may be another cause of the storage
removal failures.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
This commit is contained in:
Matthew Heon
2019-09-05 10:00:50 -04:00
parent a760e325f3
commit de9a394fcf
8 changed files with 27 additions and 20 deletions

View File

@ -44,11 +44,11 @@ func (r *Runtime) newVolume(ctx context.Context, options ...VolumeCreateOption)
volume.config.Name = stringid.GenerateNonCryptoID()
}
if volume.config.Driver == "" {
volume.config.Driver = "local"
volume.config.Driver = define.VolumeDriverLocal
}
volume.config.CreatedTime = time.Now()
if volume.config.Driver == "local" {
if volume.config.Driver == define.VolumeDriverLocal {
logrus.Debugf("Validating options for local driver")
// Validate options
for key := range volume.config.Options {