Merge pull request #14358 from vrothberg/todo-part-2

Todo part 2
This commit is contained in:
OpenShift Merge Robot
2022-05-25 10:42:23 -04:00
committed by GitHub
7 changed files with 1 additions and 16 deletions

View File

@ -144,8 +144,6 @@ func StringToType(name string) (Type, error) {
}
// StringToStatus converts a string to an Event Status
// TODO if we add more events, we might consider a go-generator to
// create the switch statement
func StringToStatus(name string) (Status, error) {
switch name {
case Attach.String():

View File

@ -53,7 +53,7 @@ func (p *Pod) GetPodPidInformation(descriptors []string) ([]string, error) {
}
}
// TODO: psgo returns a [][]string to give users the ability to apply
// NOTE: psgo returns a [][]string to give users the ability to apply
// filters on the data. We need to change the API here to return
// a [][]string if we want to make use of filtering.
opts := psgo.JoinNamespaceOpts{FillMappings: rootless.IsRootless()}