Add progress bar for decompress image

[NO NEW TESTS NEEDED]

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
This commit is contained in:
Anders F Björklund
2023-07-15 09:41:08 +02:00
parent 46058cfed9
commit d8d600b1d9

View File

@ -215,43 +215,60 @@ func Decompress(localPath, uncompressedPath string) error {
if strings.HasSuffix(localPath, ".zip") { if strings.HasSuffix(localPath, ".zip") {
isZip = true isZip = true
} }
prefix := "Copying uncompressed file"
compressionType := archive.DetectCompression(sourceFile) compressionType := archive.DetectCompression(sourceFile)
if compressionType != archive.Uncompressed || isZip { if compressionType != archive.Uncompressed || isZip {
fmt.Println("Extracting compressed file") prefix = "Extracting compressed file"
} }
prefix += ": " + filepath.Base(uncompressedPath)
if compressionType == archive.Xz { if compressionType == archive.Xz {
return decompressXZ(localPath, uncompressedFileWriter) return decompressXZ(prefix, localPath, uncompressedFileWriter)
} }
if isZip && runtime.GOOS == "windows" { if isZip && runtime.GOOS == "windows" {
return decompressZip(localPath, uncompressedFileWriter) return decompressZip(prefix, localPath, uncompressedFileWriter)
} }
return decompressEverythingElse(localPath, uncompressedFileWriter) return decompressEverythingElse(prefix, localPath, uncompressedFileWriter)
} }
// Will error out if file without .Xz already exists // Will error out if file without .Xz already exists
// Maybe extracting then renaming is a good idea here.. // Maybe extracting then renaming is a good idea here..
// depends on Xz: not pre-installed on mac, so it becomes a brew dependency // depends on Xz: not pre-installed on mac, so it becomes a brew dependency
func decompressXZ(src string, output io.WriteCloser) error { func decompressXZ(prefix string, src string, output io.WriteCloser) error {
var read io.Reader var read io.Reader
var cmd *exec.Cmd var cmd *exec.Cmd
stat, err := os.Stat(src)
if err != nil {
return err
}
file, err := os.Open(src)
if err != nil {
return err
}
defer file.Close()
p, bar := progressBar(prefix, stat.Size(), prefix+": done")
proxyReader := bar.ProxyReader(file)
defer func() {
if err := proxyReader.Close(); err != nil {
logrus.Error(err)
}
}()
// Prefer Xz utils for fastest performance, fallback to go xi2 impl // Prefer Xz utils for fastest performance, fallback to go xi2 impl
if _, err := exec.LookPath("xz"); err == nil { if _, err := exec.LookPath("xz"); err == nil {
cmd = exec.Command("xz", "-d", "-c", "-k", src) cmd = exec.Command("xz", "-d", "-c")
cmd.Stdin = proxyReader
read, err = cmd.StdoutPipe() read, err = cmd.StdoutPipe()
if err != nil { if err != nil {
return err return err
} }
cmd.Stderr = os.Stderr cmd.Stderr = os.Stderr
} else { } else {
file, err := os.Open(src)
if err != nil {
return err
}
defer file.Close()
// This XZ implementation is reliant on buffering. It is also 3x+ slower than XZ utils. // This XZ implementation is reliant on buffering. It is also 3x+ slower than XZ utils.
// Consider replacing with a faster implementation (e.g. xi2) if podman machine is // Consider replacing with a faster implementation (e.g. xi2) if podman machine is
// updated with a larger image for the distribution base. // updated with a larger image for the distribution base.
buf := bufio.NewReader(file) buf := bufio.NewReader(proxyReader)
read, err = xz.NewReader(buf) read, err = xz.NewReader(buf)
if err != nil { if err != nil {
return err return err
@ -268,18 +285,35 @@ func decompressXZ(src string, output io.WriteCloser) error {
}() }()
if cmd != nil { if cmd != nil {
return cmd.Run() err := cmd.Start()
if err != nil {
return err
}
p.Wait()
return cmd.Wait()
} }
<-done <-done
p.Wait()
return nil return nil
} }
func decompressEverythingElse(src string, output io.WriteCloser) error { func decompressEverythingElse(prefix string, src string, output io.WriteCloser) error {
stat, err := os.Stat(src)
if err != nil {
return err
}
f, err := os.Open(src) f, err := os.Open(src)
if err != nil { if err != nil {
return err return err
} }
uncompressStream, _, err := compression.AutoDecompress(f) p, bar := progressBar(prefix, stat.Size(), prefix+": done")
proxyReader := bar.ProxyReader(f)
defer func() {
if err := proxyReader.Close(); err != nil {
logrus.Error(err)
}
}()
uncompressStream, _, err := compression.AutoDecompress(proxyReader)
if err != nil { if err != nil {
return err return err
} }
@ -293,10 +327,11 @@ func decompressEverythingElse(src string, output io.WriteCloser) error {
}() }()
_, err = io.Copy(output, uncompressStream) _, err = io.Copy(output, uncompressStream)
p.Wait()
return err return err
} }
func decompressZip(src string, output io.WriteCloser) error { func decompressZip(prefix string, src string, output io.WriteCloser) error {
zipReader, err := zip.OpenReader(src) zipReader, err := zip.OpenReader(src)
if err != nil { if err != nil {
return err return err
@ -318,7 +353,16 @@ func decompressZip(src string, output io.WriteCloser) error {
logrus.Error(err) logrus.Error(err)
} }
}() }()
_, err = io.Copy(output, f) size := int64(zipReader.File[0].CompressedSize64)
p, bar := progressBar(prefix, size, prefix+": done")
proxyReader := bar.ProxyReader(f)
defer func() {
if err := proxyReader.Close(); err != nil {
logrus.Error(err)
}
}()
_, err = io.Copy(output, proxyReader)
p.Wait()
return err return err
} }