opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-22 01:48:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Podman build should default to not usins stdin

Browse Source 
Currently we leak stdin into podman builds, which can lead
to issues like run commands inside of the container waiting for
user input.

We should not take input from users other then if the user specifies
podman build -f - or podman build -, which are taken care of in other code.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
This commit is contained in:
Daniel J Walsh
2020-10-20 16:17:25 -04:00
parent 94873a237a
commit d72918fe6f
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/podman/images/build.go
View File

@ -282,8 +282,7 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *buil
flags.Layers = false flags.Layers = false
} }
var stdin, stdout, stderr, reporter *os.File var stdout, stderr, reporter *os.File
stdin = os.Stdin
stdout = os.Stdout stdout = os.Stdout
stderr = os.Stderr stderr = os.Stderr
reporter = os.Stderr reporter = os.Stderr
@ -422,7 +421,6 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *buil
ForceRmIntermediateCtrs: flags.ForceRm, ForceRmIntermediateCtrs: flags.ForceRm,
IDMappingOptions: idmappingOptions, IDMappingOptions: idmappingOptions,
IIDFile: flags.Iidfile, IIDFile: flags.Iidfile,
In: stdin,
Isolation: isolation, Isolation: isolation,
Labels: flags.Label, Labels: flags.Label,
Layers: flags.Layers, Layers: flags.Layers,