opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-11-30 01:58:46 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #27262 from Honny1/flake-investigation

Browse Source 
Fix flaky sysctl completion by handling /proc/sys errors gracefully
This commit is contained in:
openshift-merge-bot[bot]
2025-10-10 18:31:43 +00:00
committed by GitHub
parent 3e85b2ef8f 6d63d165ef
commit d5b571056e
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cmd/podman/common/completion.go
View File

@@ -1979,12 +1979,16 @@ func AutocompleteSysctl(_ *cobra.Command, _ []string, toComplete string) ([]stri
var completions []string var completions []string
sysPath := "/proc/sys" sysPath := "/proc/sys"
err := filepath.Walk(sysPath, func(path string, info os.FileInfo, err error) error { err := filepath.WalkDir(sysPath, func(path string, d fs.DirEntry, err error) error {
if err != nil { if err != nil {
return err // /proc/sys is a volatile virtual filesystem whose contents change dynamically.
// Skip directories on any error (race conditions, permission denied, etc.) to
// provide partial completion results rather than failing completely.
// See: https://github.com/containers/podman/issues/27252
return filepath.SkipDir
} }
if !info.IsDir() { if !d.IsDir() {
rel, err := filepath.Rel(sysPath, path) rel, err := filepath.Rel(sysPath, path)
if err != nil { if err != nil {
return err return err