Cleanup: fix problems reported by shell lint

Followup to #15616, which is not usable as it is (way, way, way
too much noise) but actually found a few real nits that should
be fixed.

Signed-off-by: Ed Santiago <santiago@redhat.com>
This commit is contained in:
Ed Santiago
2022-09-15 16:18:46 -06:00
parent 750726e62c
commit cfbc4aaeb5
11 changed files with 27 additions and 27 deletions

View File

@ -64,7 +64,7 @@ function is() {
local expect=$2
local testname=$3
if [[ $actual = $expect ]]; then
if [[ "$actual" = "$expect" ]]; then
# On success, include expected value; this helps readers understand
_show_ok 1 "$testname=$expect"
return
@ -303,12 +303,12 @@ n_tests=0
# We aren't really TAP 13; this helps logformatter recognize our output as BATS
echo "TAP version 13"
for t in ${tests_to_run[@]}; do
for t in "${tests_to_run[@]}"; do
testdir="$(dirname $t)"
testname="$(basename $testdir)"
if [ -e $test_dir/SKIP ]; then
local reason="$(<$test_dir/SKIP)"
reason="$(<$test_dir/SKIP)"
if [ -n "$reason" ]; then
reason=" - $reason"
fi