opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-24 03:08:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

CI: e2e: safer GetPort()

Browse Source 
Problem: frequent CI flakes of the form:

   Error: cannot listen on the TCP port: listen tcp4 :5355: bind: address already in use

Always 5355.

Cause: systemd-resolve listens on 5355, but not on 127.0.0.1. So
when GetPort() tries its is-it-in-use check by binding localhost,
it succeeds; but then podman binds * and fails.

Solution: GetPort(): test by binding 0.0.0.0.

Also, improve the failure message.

Signed-off-by: Ed Santiago <santiago@redhat.com>
This commit is contained in:
Ed Santiago
2023-10-26 05:47:44 -06:00
parent 642c0c798a
commit c841fa9e9a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/e2e/common_test.go
View File

@ -1233,7 +1233,7 @@ func GetPort() int {
// Random port within that range // Random port within that range
port := portMin + rng.Intn((portMax-portMin)/nProcs)*nProcs + myProc port := portMin + rng.Intn((portMax-portMin)/nProcs)*nProcs + myProc
used, err := net.Listen("tcp", "localhost:"+strconv.Itoa(port)) used, err := net.Listen("tcp", "0.0.0.0:"+strconv.Itoa(port))
if err == nil { if err == nil {
// it's open. Return it. // it's open. Return it.
err = used.Close() err = used.Close()
@ -1242,7 +1242,7 @@ func GetPort() int {
} }
} }
Fail(fmt.Sprintf("unable to get free port: %v", err)) Fail(fmt.Sprintf("unable to get free port in range %d-%d", portMin, portMax))
return 0 // notreached return 0 // notreached
} }