opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-07-19 19:42:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix #11444: remote breaks with stdout redirection

Browse Source 
`setConsoleMode` should do nothing if the handle is not a terminal. The proposed change is [exactly what `golang.org/x/term/IsTerminal()` does on Windows](https://cs.opensource.google/go/x/term/+/6886f2df:term_windows.go).

[NO TESTS NEEDED]

Signed-off-by: Anton Tykhyy <atykhyy@gmail.com>
This commit is contained in:
Anton Tykhyy
2021-09-13 17:42:48 +03:00
committed by GitHub
parent 0f3d3bd21d
commit c23f81fab6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/terminal/console_windows.go
View File

@ -25,7 +25,7 @@ func setConsoleMode(handle windows.Handle, flags uint32) error {
var mode uint32 var mode uint32
err := windows.GetConsoleMode(handle, &mode) err := windows.GetConsoleMode(handle, &mode)
if err != nil { if err != nil {
return err return nil // not a terminal
} }
if err := windows.SetConsoleMode(handle, mode|flags); err != nil { if err := windows.SetConsoleMode(handle, mode|flags); err != nil {
// In similar code, it is not considered an error if we cannot set the // In similar code, it is not considered an error if we cannot set the