opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-29 06:57:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Skip seccomp-dependent tests on non-Linux

Browse Source 
Currently, getRuntimeSpec always fails on non-Linux because
spec.CreateConfigToOCISpec always fails, because the podman CLI
sets up a seccomp path, and processing that on non-Linux is not supported.  This
breaks testing of entirely unrelated options.

We can either skip the tests on non-Linux, or explicitly disable seccomp
inside the tests.  Linux testing matters much more than other platforms,
and the tests are more reliable when they don't change supposedly
unrelated options; so, skip the tests on non-Linux.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>

Closes: #1115
Approved by: rhatdan
This commit is contained in:
Miloslav Trmač
2018-07-18 21:11:10 +02:00
committed by Atomic Bot
parent 2322f272c4
commit c142409598
1 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
cmd/podman/run_test.go
View File

@ -1,6 +1,7 @@
package main package main
import ( import (
"runtime"
"testing" "testing"
units "github.com/docker/go-units" units "github.com/docker/go-units"
@ -90,6 +91,12 @@ func getRuntimeSpec(c *cli.Context) (*spec.Spec, error) {
// TestPIDsLimit verifies the inputted pid-limit is correctly defined in the spec // TestPIDsLimit verifies the inputted pid-limit is correctly defined in the spec
func TestPIDsLimit(t *testing.T) { func TestPIDsLimit(t *testing.T) {
// The default configuration of podman enables seccomp, which is not available on non-Linux systems.
// Thus, any tests that use the default seccomp setting would fail.
// Skip the tests on non-Linux platforms rather than explicitly disable seccomp in the test and possibly affect the test result.
if runtime.GOOS != "linux" {
t.Skip("seccomp, which is enabled by default, is only supported on Linux")
}
a := createCLI() a := createCLI()
args := []string{"--pids-limit", "22"} args := []string{"--pids-limit", "22"}
a.Run(append(cmd, args...)) a.Run(append(cmd, args...))
@ -102,6 +109,12 @@ func TestPIDsLimit(t *testing.T) {
// TestBLKIOWeightDevice verifies the inputted blkio weigh device is correctly defined in the spec // TestBLKIOWeightDevice verifies the inputted blkio weigh device is correctly defined in the spec
func TestBLKIOWeightDevice(t *testing.T) { func TestBLKIOWeightDevice(t *testing.T) {
// The default configuration of podman enables seccomp, which is not available on non-Linux systems.
// Thus, any tests that use the default seccomp setting would fail.
// Skip the tests on non-Linux platforms rather than explicitly disable seccomp in the test and possibly affect the test result.
if runtime.GOOS != "linux" {
t.Skip("seccomp, which is enabled by default, is only supported on Linux")
}
a := createCLI() a := createCLI()
args := []string{"--blkio-weight-device", "/dev/zero:100"} args := []string{"--blkio-weight-device", "/dev/zero:100"}
a.Run(append(cmd, args...)) a.Run(append(cmd, args...))
@ -114,6 +127,12 @@ func TestBLKIOWeightDevice(t *testing.T) {
// TestMemorySwap verifies that the inputted memory swap is correctly defined in the spec // TestMemorySwap verifies that the inputted memory swap is correctly defined in the spec
func TestMemorySwap(t *testing.T) { func TestMemorySwap(t *testing.T) {
// The default configuration of podman enables seccomp, which is not available on non-Linux systems.
// Thus, any tests that use the default seccomp setting would fail.
// Skip the tests on non-Linux platforms rather than explicitly disable seccomp in the test and possibly affect the test result.
if runtime.GOOS != "linux" {
t.Skip("seccomp, which is enabled by default, is only supported on Linux")
}
a := createCLI() a := createCLI()
args := []string{"--memory-swap", "45m", "--memory", "40m"} args := []string{"--memory-swap", "45m", "--memory", "40m"}
a.Run(append(cmd, args...)) a.Run(append(cmd, args...))