opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-12-02 02:58:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't set hostPort when generating a service

Browse Source 
When generating a kube yaml with kube generate, do not
set the hostPort in the pod spec if the service flag is
set and we are generating a service kind too.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
This commit is contained in:
Urvashi Mohnani
2023-02-14 10:18:14 -05:00
parent 1e06c1a47a
commit c0f983db87
3 changed files with 55 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
test/e2e/generate_kube_test.go
View File

@@ -150,6 +150,43 @@ var _ = Describe("Podman kube generate", func() {
Expect(err).ToNot(HaveOccurred())
})
It("podman generate kube on container with and without service", func() {
session := podmanTest.Podman([]string{"create", "--name", "test-ctr", "-p", "3890:3890", ALPINE, "ls"})
session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0))
kube := podmanTest.Podman([]string{"kube", "generate", "-s", "test-ctr"})
kube.WaitWithDefaultTimeout()
Expect(kube).Should(Exit(0))
// Separate out the Service and Pod yaml
arr := strings.Split(string(kube.Out.Contents()), "---")
Expect(arr).To(HaveLen(2))
svc := new(v1.Service)
err := yaml.Unmarshal([]byte(arr[0]), svc)
Expect(err).ToNot(HaveOccurred())
Expect(svc.Spec.Ports).To(HaveLen(1))
Expect(svc.Spec.Ports[0].TargetPort.IntValue()).To(Equal(3890))
pod := new(v1.Pod)
err = yaml.Unmarshal([]byte(arr[1]), pod)
Expect(err).ToNot(HaveOccurred())
// Since hostPort will not be set in the yaml, when we unmarshal it it will have a value of 0
Expect(pod.Spec.Containers[0].Ports[0].HostPort).To(Equal(int32(0)))
// Now do kube generate without the --service flag
kube = podmanTest.Podman([]string{"kube", "generate", "test-ctr"})
kube.WaitWithDefaultTimeout()
Expect(kube).Should(Exit(0))
// The hostPort in the pod yaml should be set to 3890
pod = new(v1.Pod)
err = yaml.Unmarshal(kube.Out.Contents(), pod)
Expect(err).ToNot(HaveOccurred())
Expect(pod.Spec.Containers[0].Ports[0].HostPort).To(Equal(int32(3890)))
})
It("podman generate kube on pod", func() {
_, rc, _ := podmanTest.CreatePod(map[string][]string{"--name": {"toppod"}})
Expect(rc).To(Equal(0))