From c023b789f28bdbf6f3ee61aaf8c68c8ae7c1cafc Mon Sep 17 00:00:00 2001 From: Jake Correnti Date: Tue, 6 Feb 2024 16:14:10 -0500 Subject: [PATCH] Re-enable passing a logfile to gvproxy Re-enable the commented-out code that passed the path to a logfile to gvproxy when the user passes `--log-level=debug` Signed-off-by: Jake Correnti --- pkg/machine/shim/networking.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pkg/machine/shim/networking.go b/pkg/machine/shim/networking.go index 21277936ad..914bc0e502 100644 --- a/pkg/machine/shim/networking.go +++ b/pkg/machine/shim/networking.go @@ -73,11 +73,9 @@ func startNetworking(mc *vmconfigs.MachineConfig, provider vmconfigs.VMProvider) // GvProxy PID file path is now derived cmd.PidFile = filepath.Join(runDir.GetPath(), "gvproxy.pid") - // TODO This can be re-enabled when gvisor-tap-vsock #305 is merged - // debug is set, we dump to a logfile as well - // if logrus.IsLevelEnabled(logrus.DebugLevel) { - // cmd.LogFile = filepath.Join(runDir.GetPath(), "gvproxy.log") - // } + if logrus.IsLevelEnabled(logrus.DebugLevel) { + cmd.LogFile = filepath.Join(runDir.GetPath(), "gvproxy.log") + } cmd.SSHPort = mc.SSH.Port