opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-19 16:33:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Better pull error for fully-qualified images

Browse Source 
When pulling a fully-qualified image that fails, we should not be talking about
registries/search registries in the the error message as it is not applicable.  If
a image that is fq'd and fails to pull, the error should be simplified.

```
$ sudo podman pull this-does-not-exist.example.com/foo
Trying to pull this-does-not-exist.example.com/foo...Failed
error pulling image "this-does-not-exist.example.com/foo": unable to pull this-does-not-exist.example.com/foo: unable to pull image, or you do not have pull access
$
```

Resolves: #1212
Signed-off-by: baude <bbaude@redhat.com>

Closes: #1216
Approved by: mheon
This commit is contained in:
baude
2018-08-04 10:30:16 -05:00
committed by Atomic Bot
parent e90909735c
commit b1de943eea
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libpod/image/pull.go
View File

@ -272,7 +272,12 @@ func (ir *Runtime) doPullImage(ctx context.Context, sc *types.SystemContext, goa
if goal.usedSearchRegistries && len(goal.searchedRegistries) == 0 { if goal.usedSearchRegistries && len(goal.searchedRegistries) == 0 {
return nil, errors.Errorf("image name provided is a short name and no search registries are defined in %s.", registryPath) return nil, errors.Errorf("image name provided is a short name and no search registries are defined in %s.", registryPath)
} }
// If the image passed in was fully-qualified, we will have 1 refpair. Bc the image is fq'd, we dont need to yap about registries.
if !goal.usedSearchRegistries {
return nil, errors.Errorf("unable to pull image, or you do not have pull access")
}
return nil, errors.Errorf("unable to find image on registries defined in %s, or you do not have pull access", registryPath) return nil, errors.Errorf("unable to find image on registries defined in %s, or you do not have pull access", registryPath)
} }
return images, nil return images, nil
} }