Merge pull request #6570 from rhatdan/remote

Change buildtag for remoteclient to remote for testing

test/e2e/attach_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/build_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/checkpoint_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/common_test.go

@@ -468,6 +468,10 @@ func (p *PodmanTestIntegration) CleanupVolume() {
 	// Remove all containers
 	session := p.Podman([]string{"volume", "rm", "-fa"})
 	session.Wait(90)
+
+	// Stop remove service on volume cleanup
+	p.StopRemoteService()
+
 	// Nuke tempdir
 	if err := os.RemoveAll(p.TempDir); err != nil {
 		fmt.Printf("%q\n", err)

test/e2e/containers_conf_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/cp_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 
@@ -142,7 +142,6 @@ var _ = Describe("Podman cp", func() {
 
 	It("podman cp stdin/stdout", func() {
 		SkipIfRemote()
-		Skip("Looks like SkipIfRemote() is not working")
 		session := podmanTest.Podman([]string{"create", ALPINE, "ls", "foo"})
 		session.WaitWithDefaultTimeout()
 		Expect(session.ExitCode()).To(Equal(0))

test/e2e/create_staticip_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/create_staticmac_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/create_test.go

@@ -107,6 +107,7 @@ var _ = Describe("Podman create", func() {
 	})
 
 	It("podman create --entrypoint \"\"", func() {
+		Skip(v2remotefail)
 		session := podmanTest.Podman([]string{"create", "--entrypoint", "", ALPINE, "ls"})
 		session.WaitWithDefaultTimeout()
 		Expect(session.ExitCode()).To(Equal(0))

test/e2e/exec_test.go

@@ -79,6 +79,7 @@ var _ = Describe("Podman exec", func() {
 	})
 
 	It("podman exec environment test", func() {
+		Skip(v2remotefail)
 		setup := podmanTest.RunTopContainer("test1")
 		setup.WaitWithDefaultTimeout()
 		Expect(setup.ExitCode()).To(Equal(0))
@@ -123,6 +124,7 @@ var _ = Describe("Podman exec", func() {
 	})
 
 	It("podman exec terminal doesn't hang", func() {
+		Skip(v2remotefail)
 		setup := podmanTest.Podman([]string{"run", "-dti", fedoraMinimal, "sleep", "+Inf"})
 		setup.WaitWithDefaultTimeout()
 		Expect(setup.ExitCode()).To(Equal(0))
@@ -157,6 +159,7 @@ var _ = Describe("Podman exec", func() {
 	})
 
 	It("podman exec with user only in container", func() {
+		Skip(v2remotefail)
 		testUser := "test123"
 		setup := podmanTest.Podman([]string{"run", "--name", "test1", "-d", fedoraMinimal, "sleep", "60"})
 		setup.WaitWithDefaultTimeout()
@@ -173,6 +176,7 @@ var _ = Describe("Podman exec", func() {
 	})
 
 	It("podman exec with user from run", func() {
+		Skip(v2remotefail)
 		testUser := "guest"
 		setup := podmanTest.Podman([]string{"run", "--user", testUser, "-d", ALPINE, "top"})
 		setup.WaitWithDefaultTimeout()
@@ -192,6 +196,7 @@ var _ = Describe("Podman exec", func() {
 	})
 
 	It("podman exec simple working directory test", func() {
+		Skip(v2remotefail)
 		setup := podmanTest.RunTopContainer("test1")
 		setup.WaitWithDefaultTimeout()
 		Expect(setup.ExitCode()).To(Equal(0))
@@ -210,6 +215,7 @@ var _ = Describe("Podman exec", func() {
 	})
 
 	It("podman exec missing working directory test", func() {
+		Skip(v2remotefail)
 		setup := podmanTest.RunTopContainer("test1")
 		setup.WaitWithDefaultTimeout()
 		Expect(setup.ExitCode()).To(Equal(0))
@@ -224,6 +230,7 @@ var _ = Describe("Podman exec", func() {
 	})
 
 	It("podman exec cannot be invoked", func() {
+		Skip(v2remotefail)
 		setup := podmanTest.RunTopContainer("test1")
 		setup.WaitWithDefaultTimeout()
 		Expect(setup.ExitCode()).To(Equal(0))
@@ -234,6 +241,7 @@ var _ = Describe("Podman exec", func() {
 	})
 
 	It("podman exec command not found", func() {
+		Skip(v2remotefail)
 		setup := podmanTest.RunTopContainer("test1")
 		setup.WaitWithDefaultTimeout()
 		Expect(setup.ExitCode()).To(Equal(0))

test/e2e/generate_kube_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/generate_systemd_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/images_test.go

@@ -176,6 +176,7 @@ var _ = Describe("Podman images", func() {
 	})
 
 	It("podman images filter before image", func() {
+		Skip(v2remotefail)
 		dockerfile := `FROM docker.io/library/alpine:latest
 RUN apk update && apk add strace
 `
@@ -187,6 +188,7 @@ RUN apk update && apk add strace
 	})
 
 	It("podman images workingdir from  image", func() {
+		Skip(v2remotefail)
 		dockerfile := `FROM docker.io/library/alpine:latest
 WORKDIR /test
 `
@@ -306,6 +308,7 @@ WORKDIR /test
 	})
 
 	It("podman images --all flag", func() {
+		Skip(v2remotefail)
 		podmanTest.RestoreAllArtifacts()
 		dockerfile := `FROM docker.io/library/alpine:latest
 RUN mkdir hello
@@ -325,6 +328,7 @@ ENV foo=bar
 	})
 
 	It("podman images filter by label", func() {
+		Skip(v2remotefail)
 		dockerfile := `FROM docker.io/library/alpine:latest
 LABEL version="1.0"
 LABEL "com.example.vendor"="Example Vendor"
@@ -337,6 +341,7 @@ LABEL "com.example.vendor"="Example Vendor"
 	})
 
 	It("podman with images with no layers", func() {
+		Skip(v2remotefail)
 		dockerfile := strings.Join([]string{
 			`FROM scratch`,
 			`LABEL org.opencontainers.image.authors="<somefolks@example.org>"`,

test/e2e/import_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/libpod_suite_remote_test.go

@@ -1,4 +1,4 @@
-// +build remoteclient
+// +build remote
 
 package integration
 

test/e2e/libpod_suite_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/load_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/login_logout_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/logs_test.go

@@ -273,6 +273,7 @@ var _ = Describe("Podman logs", func() {
 	})
 
 	It("streaming output", func() {
+		Skip(v2remotefail)
 		containerName := "logs-f-rm"
 
 		logc := podmanTest.Podman([]string{"run", "--rm", "--name", containerName, "-dt", ALPINE, "sh", "-c", "echo podman; sleep 1; echo podman"})
@@ -313,6 +314,7 @@ var _ = Describe("Podman logs", func() {
 	})
 
 	It("follow output stopped container", func() {
+		Skip(v2remotefail)
 		containerName := "logs-f"
 
 		logc := podmanTest.Podman([]string{"run", "--name", containerName, "-d", ALPINE, "true"})

test/e2e/mount_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/namespace_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/network_create_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/network_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/play_kube_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/pod_infra_container_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/pod_inspect_test.go

@@ -59,6 +59,7 @@ var _ = Describe("Podman pod inspect", func() {
 	})
 
 	It("podman pod inspect (CreateCommand)", func() {
+		Skip(v2remotefail)
 		podName := "myTestPod"
 		createCommand := []string{"pod", "create", "--name", podName, "--hostname", "rudolph", "--share", "net"}
 

test/e2e/pod_pod_namespaces.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/pod_stats_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/pod_top_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/port_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/pull_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/push_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_cgroup_parent_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_cleanup_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_cpu_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_device_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_dns_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_entrypoint_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_env_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_memory_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_networking_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_ns_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_passwd_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_privileged_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_restart_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_seccomp.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_security_labels.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_selinux_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_signal_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_staticip_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_userns_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/run_volume_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/runlabel_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/search_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/start_test.go

@@ -120,6 +120,7 @@ var _ = Describe("Podman start", func() {
 	})
 
 	It("podman failed to start with --rm should delete the container", func() {
+		Skip(v2remotefail)
 		session := podmanTest.Podman([]string{"create", "--name", "test1", "-it", "--rm", ALPINE, "foo"})
 		session.WaitWithDefaultTimeout()
 		Expect(session.ExitCode()).To(Equal(0))

test/e2e/stats_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/stop_test.go

@@ -198,6 +198,7 @@ var _ = Describe("Podman stop", func() {
 	})
 
 	It("podman stop all containers with one stopped", func() {
+		Skip(v2remotefail)
 		session := podmanTest.RunTopContainer("test1")
 		session.WaitWithDefaultTimeout()
 		Expect(session.ExitCode()).To(Equal(0))

test/e2e/system_df_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/systemd_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/top_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/trust_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration
 

test/e2e/untag_test.go

@@ -33,6 +33,7 @@ var _ = Describe("Podman untag", func() {
 	})
 
 	It("podman untag all", func() {
+		Skip(v2remotefail)
 		tags := []string{ALPINE, "registry.com/foo:bar", "localhost/foo:bar"}
 
 		cmd := []string{"tag"}

test/e2e/volume_prune_test.go

@@ -1,4 +1,4 @@
-// +build !remoteclient
+// +build !remote
 
 package integration