From b011aa443018dd5db5061c6a903c2eac4a2dccd0 Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Thu, 7 Dec 2023 16:39:22 +0100 Subject: [PATCH] cli: podman run/create --env-file use StringArray() This option accepts a file path so we should allow commas in it. Signed-off-by: Paul Holzinger --- cmd/podman/common/create.go | 2 +- test/system/300-cli-parsing.bats | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/podman/common/create.go b/cmd/podman/common/create.go index 3c3a580497..435afbc77b 100644 --- a/cmd/podman/common/create.go +++ b/cmd/podman/common/create.go @@ -147,7 +147,7 @@ func DefineCreateFlags(cmd *cobra.Command, cf *entities.ContainerCreateOptions, } envFileFlagName := "env-file" - createFlags.StringSliceVar( + createFlags.StringArrayVar( &cf.EnvFile, envFileFlagName, []string{}, "Read in a file of environment variables", diff --git a/test/system/300-cli-parsing.bats b/test/system/300-cli-parsing.bats index 12ab4dcb6a..63a16aaa9a 100644 --- a/test/system/300-cli-parsing.bats +++ b/test/system/300-cli-parsing.bats @@ -196,7 +196,7 @@ EOF fi # Same, with --env-file - local envfile="$PODMAN_TMPDIR/envfile-in-1" + local envfile="$PODMAN_TMPDIR/envfile-in-1,withcomma" cat >$envfile <