From ac18b1a0af286934f111c740052950da794abade Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Thu, 29 Aug 2024 15:00:48 +0200 Subject: [PATCH] cirrus: remove 3rd party connectivity check This doesn't help us at all, first the list is outdated. AFAICT we no longer connect to docker.io, registry.fedoraproject.org or podman.cachix.org (seems to be a cache site for nix.dev?) anywhere in our tests. Second a simple port check is not helpful, in the most cases the CDN's and or load balancer accept connections but return internal server errors when the registy goes down. This is very similar to commit 5b6de98ee8. Signed-off-by: Paul Holzinger --- contrib/cirrus/prebuild.sh | 16 ---------------- contrib/cirrus/required_host_ports.txt | 5 ----- 2 files changed, 21 deletions(-) delete mode 100644 contrib/cirrus/required_host_ports.txt diff --git a/contrib/cirrus/prebuild.sh b/contrib/cirrus/prebuild.sh index 65c254f556..22b101cc4f 100755 --- a/contrib/cirrus/prebuild.sh +++ b/contrib/cirrus/prebuild.sh @@ -81,19 +81,3 @@ if [[ "${DISTRO_NV}" == "$PRIOR_FEDORA_NAME" ]]; then showrun bash ${CIRRUS_WORKING_DIR}/.github/actions/check_cirrus_cron/test.sh fi fi - -msg "Checking 3rd party network service connectivity" -# shellcheck disable=SC2154 -cat ${CIRRUS_WORKING_DIR}/${SCRIPT_BASE}/required_host_ports.txt | \ - while read host port - do - if [[ "$port" -eq "443" ]] - then - echo "SSL/TLS to $host:$port" - echo -n '' | \ - err_retry 9 1000 "" openssl s_client -quiet -no_ign_eof -connect $host:$port - else - echo "Connect to $host:$port" - err_retry 9 1000 1 nc -zv -w 13 $host $port - fi - done diff --git a/contrib/cirrus/required_host_ports.txt b/contrib/cirrus/required_host_ports.txt deleted file mode 100644 index 5f066e059c..0000000000 --- a/contrib/cirrus/required_host_ports.txt +++ /dev/null @@ -1,5 +0,0 @@ -github.com 22 -docker.io 443 -quay.io 443 -registry.fedoraproject.org 443 -podman.cachix.org 443