opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-26 04:46:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Prevent nil pointer deref in GetImage

Browse Source 
Trying to print the image id on a failed inspect will result in a nil
pointer panic because the image will be nil.  Replace image.id with the
image name which is defined as a string without the use of inspect.

Fixes: bz#2131836

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
This commit is contained in:
Brent Baude
2022-10-04 15:12:27 -05:00
parent 0330d1abed
commit aaa9f4ea90
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/api/handlers/compat/images.go
View File

@ -403,7 +403,7 @@ func GetImage(w http.ResponseWriter, r *http.Request) {
} }
inspect, err := handlers.ImageDataToImageInspect(r.Context(), newImage) inspect, err := handlers.ImageDataToImageInspect(r.Context(), newImage)
if err != nil { if err != nil {
utils.Error(w, http.StatusInternalServerError, fmt.Errorf("failed to convert ImageData to ImageInspect '%s': %w", inspect.ID, err)) utils.Error(w, http.StatusInternalServerError, fmt.Errorf("failed to convert ImageData to ImageInspect '%s': %w", name, err))
return return
} }
utils.WriteResponse(w, http.StatusOK, inspect) utils.WriteResponse(w, http.StatusOK, inspect)