opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-29 15:08:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix podman system connection - tcp flake

Browse Source 
The test was only waiting for the port to be ready but that doesn't
imply the server being ready to serve requests.  Hence, add a loop
waiting for the `info` call to succeed.

Fixes: #16916
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
This commit is contained in:
Valentin Rothberg
2022-12-23 10:43:28 +01:00
parent 3fbf62e968
commit a741299efc
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/system/272-system-connection.bats
View File

@ -112,9 +112,17 @@ $c2[ ]\+tcp://localhost:54321[ ]\+true" \
--runroot ${PODMAN_TMPDIR}/runroot \ --runroot ${PODMAN_TMPDIR}/runroot \
system service -t 99 tcp://localhost:$_SERVICE_PORT & system service -t 99 tcp://localhost:$_SERVICE_PORT &
_SERVICE_PID=$! _SERVICE_PID=$!
# Wait for the port and the podman-service to be ready.
wait_for_port localhost $_SERVICE_PORT wait_for_port localhost $_SERVICE_PORT
local timeout=10
_run_podman_remote info --format '{{.Host.RemoteSocket.Path}}' while [[ $timeout -gt 1 ]]; do
_run_podman_remote ? info --format '{{.Host.RemoteSocket.Path}}'
if [[ $status == 0 ]]; then
break
fi
sleep 1
let timeout=$timeout-1
done
is "$output" "tcp://localhost:$_SERVICE_PORT" \ is "$output" "tcp://localhost:$_SERVICE_PORT" \
"podman info works, and talks to the correct server" "podman info works, and talks to the correct server"