opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-10-18 19:53:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Print headers for system connection ls

Browse Source 
Print out the headers even if the system connection list
is empty to match the behavior of other list commands.

Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
This commit is contained in:
Urvashi Mohnani
2021-11-09 10:01:51 -05:00
parent 4bf0146c29
commit a55fdbb49c
3 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/podman/system/connection/list.go
View File

@ -53,10 +53,6 @@ func list(cmd *cobra.Command, _ []string) error {
return err return err
} }
if len(cfg.Engine.ServiceDestinations) == 0 {
return nil
}
hdrs := []map[string]string{{ hdrs := []map[string]string{{
"Identity": "Identity", "Identity": "Identity",
"Name": "Name", "Name": "Name",

2
test/e2e/system_connection_test.go
View File

@ -236,7 +236,7 @@ var _ = Describe("podman system connection", func() {
session := podmanTest.Podman(cmd) session := podmanTest.Podman(cmd)
session.WaitWithDefaultTimeout() session.WaitWithDefaultTimeout()
Expect(session).Should(Exit(0)) Expect(session).Should(Exit(0))
Expect(session.Out.Contents()).Should(BeEmpty()) Expect(len(session.OutputToStringArray())).Should(Equal(1))
Expect(session.Err.Contents()).Should(BeEmpty()) Expect(session.Err.Contents()).Should(BeEmpty())
}) })
}) })

3
test/system/272-system-connection.bats
View File

@ -50,7 +50,8 @@ function _run_podman_remote() {
# Very basic test, does not actually connect at any time # Very basic test, does not actually connect at any time
@test "podman system connection - basic add / ls / remove" { @test "podman system connection - basic add / ls / remove" {
run_podman system connection ls run_podman system connection ls
is "$output" "" "system connection ls: no connections" is "$output" "Name URI Identity Default" \
"system connection ls: no connections"
c1="c1_$(random_string 15)" c1="c1_$(random_string 15)"
c2="c2_$(random_string 15)" c2="c2_$(random_string 15)"