First batch of resolutions to FIXMEs

Most of these are no longer relevant, just drop the comments.

Most notable change: allow `podman kill` on paused containers.
Works just fine when I test it.

Signed-off-by: Matthew Heon <mheon@redhat.com>
This commit is contained in:
Matthew Heon
2022-05-23 13:27:04 -04:00
parent 819e5bcb94
commit 9fcfea7643
7 changed files with 25 additions and 13 deletions

View File

@ -202,9 +202,8 @@ func (c *Container) Kill(signal uint) error {
}
}
// TODO: Is killing a paused container OK?
switch c.state.State {
case define.ContainerStateRunning, define.ContainerStateStopping:
case define.ContainerStateRunning, define.ContainerStateStopping, define.ContainerStatePaused:
// Note that killing containers in "stopping" state is okay.
// In that state, the Podman is waiting for the runtime to
// stop the container and if that is taking too long, a user