From 9d47477e8269fb4e7a152862be49f6c33b20e1ed Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Tue, 19 Aug 2025 17:24:42 +0200 Subject: [PATCH] cirrus: fix podman machine windows only_if condition The winmake target is critical for the machine task as this is used to actually run the ginkgo command line. PR #26847 modified that line will not actually running the tests which means it is easy to break CI with this. Now the chnage of the PR was correct so it worked fine this time but for the future make sure we actually run the tests in such cases. Signed-off-by: Paul Holzinger --- .cirrus.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 6db5aae1c8..92cf1eab86 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -817,7 +817,13 @@ podman_machine_windows_task: name: *std_name_fmt alias: podman_machine_windows # Docs: ./contrib/cirrus/CIModes.md - only_if: *only_if_machine_test + # Duplicated from the main linux machine task as we also must match winmake.ps1 here since that is used on windows. + only_if: >- + $CIRRUS_PR == '' || + $CIRRUS_CHANGE_TITLE =~ '.*CI:ALL.*' || + changesInclude('.cirrus.yml', 'Makefile', 'contrib/cirrus/**', 'vendor/**', 'test/tools/**', 'test/registries*.conf', 'hack/**', 'version/rawversion/*') || + changesInclude('winmake.ps1') || + changesInclude('cmd/podman/machine/**', 'pkg/machine/**', '**/*machine*.go') # Special case, we do not run macos/windows builds on rhel branches. # Thus the machine task should not be run too, while we use only_if # everywhere to do so here it would mean we would need duplicate the