opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-05-20 00:27:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

make image reference for commit optional

Browse Source 
to match docker compat, the image tag should be optional.

Fixes: #5027

Signed-off-by: Brent Baude <bbaude@redhat.com>
This commit is contained in:
Brent Baude
2020-01-30 09:50:06 -06:00
parent ee0b328b72
commit 9bbf08de25
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/podman/commit.go
View File

@ -56,12 +56,15 @@ func commitCmd(c *cliconfig.CommitValues) error {
defer runtime.DeferredShutdown(false) defer runtime.DeferredShutdown(false)
args := c.InputArgs args := c.InputArgs
if len(args) != 2 { if len(args) < 1 {
return errors.Errorf("you must provide a container name or ID and a target image name") return errors.Errorf("you must provide a container name or ID and optionally a target image name")
} }
container := args[0] container := args[0]
reference := args[1] reference := ""
if len(args) > 1 {
reference = args[1]
}
if c.Flag("change").Changed { if c.Flag("change").Changed {
for _, change := range c.Change { for _, change := range c.Change {
splitChange := strings.Split(strings.ToUpper(change), "=") splitChange := strings.Split(strings.ToUpper(change), "=")

2
docs/source/markdown/podman-commit.1.md
View File

@ -6,7 +6,7 @@ podman\-commit - Create new image based on the changed container
## SYNOPSIS ## SYNOPSIS
**podman commit** [*options*] *container* *image* **podman commit** [*options*] *container* *image*
**podman container commit** [*options*] *container* *image* **podman container commit** [*options*] *container* [*image*]
## DESCRIPTION ## DESCRIPTION
**podman commit** creates an image based on a changed container. The author of the **podman commit** creates an image based on a changed container. The author of the