mirror of
https://github.com/containers/podman.git
synced 2025-12-09 23:27:09 +08:00
e2e tests: clean up antihelpful BeTrue()s
Many ginkgo tests have been written to use this evil form:
GrepString("foo")
Expect(that to BeTrue())
...which yields horrible useless messages on failure:
false is not true
Identify those (automatically, via script) and convert to:
Expect(output to ContainSubstring("foo"))
...which yields:
"this output" does not contain substring "foo"
There are still many BeTrue()s left. This is just a start.
This is commit 1 of 2. It includes the script I used, and
all changes to *.go are those computed by the script.
Commit 2 will apply some manual fixes.
Signed-off-by: Ed Santiago <santiago@redhat.com>
This commit is contained in:
@@ -60,7 +60,7 @@ WORKDIR /etc/foobar`, ALPINE)
|
||||
|
||||
session = podmanTest.Podman([]string{"run", "test", "ls", "-ld", "."})
|
||||
session.WaitWithDefaultTimeout()
|
||||
Expect(session.LineInOutputContains("bin")).To(BeTrue())
|
||||
Expect(session.OutputToString()).To(ContainSubstring("bin"))
|
||||
|
||||
session = podmanTest.Podman([]string{"run", "--workdir", "/home/foobar", "test", "pwd"})
|
||||
session.WaitWithDefaultTimeout()
|
||||
|
||||
Reference in New Issue
Block a user