mirror of
https://github.com/containers/podman.git
synced 2025-06-19 16:33:24 +08:00
e2e tests: clean up antihelpful BeTrue()s
Many ginkgo tests have been written to use this evil form: GrepString("foo") Expect(that to BeTrue()) ...which yields horrible useless messages on failure: false is not true Identify those (automatically, via script) and convert to: Expect(output to ContainSubstring("foo")) ...which yields: "this output" does not contain substring "foo" There are still many BeTrue()s left. This is just a start. This is commit 1 of 2. It includes the script I used, and all changes to *.go are those computed by the script. Commit 2 will apply some manual fixes. Signed-off-by: Ed Santiago <santiago@redhat.com>
This commit is contained in:
@ -42,8 +42,7 @@ var _ = Describe("Podman pod create", func() {
|
||||
|
||||
check := podmanTest.Podman([]string{"pod", "ps", "-q", "--no-trunc"})
|
||||
check.WaitWithDefaultTimeout()
|
||||
match, _ := check.GrepString(podID)
|
||||
Expect(match).To(BeTrue())
|
||||
Expect(check.OutputToString()).To(ContainSubstring(podID))
|
||||
Expect(len(check.OutputToStringArray())).To(Equal(1))
|
||||
|
||||
check = podmanTest.Podman([]string{"ps", "-qa", "--no-trunc"})
|
||||
|
Reference in New Issue
Block a user