opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-10-19 20:23:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make error messages more descriptive

Browse Source 
Recently was trying to start podman machine with krunkit and got:

Error: krunkit exited unexpectedly with exit code 1

which isn't very descriptive. Although this doesn't solve the
issue, it increases the debugability of this error.

Signed-off-by: Eric Curtin <ecurtin@redhat.com>
This commit is contained in:
Eric Curtin
2024-10-14 13:40:05 +01:00
parent 0894cec14d
commit 94dcf76eb2
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/machine/apple/apple.go
View File

@ -360,8 +360,14 @@ func CheckProcessRunning(processName string, pid int) error {
return fmt.Errorf("failed to read %s process status: %w", processName, err) return fmt.Errorf("failed to read %s process status: %w", processName, err)
} }
if pid > 0 { if pid > 0 {
// child exited // Child exited, process is no longer running
return fmt.Errorf("%s exited unexpectedly with exit code %d", processName, status.ExitStatus()) if status.Exited() {
return fmt.Errorf("%s exited unexpectedly with exit code %d", processName, status.ExitStatus())
}
if status.Signaled() {
return fmt.Errorf("%s was terminated by signal: %s", processName, status.Signal().String())
}
return fmt.Errorf("%s exited unexpectedly", processName)
} }
return nil return nil
} }