set !remote build tags where needed

The new golangci-lint version 1.60.1 has problems with typecheck when
linting remote files. We have certain pakcages that should never be
inlcuded in remote but the typecheck tries to compile all of them but
this never works and it seems to ignore the exclude files we gave it.

To fix this the proper way is to mark all packages we only use locally
with !remote tags. This is a bit ugly but more correct. I also moved the
DecodeChanges() code around as it is called from the client so the
handles package which should only be remote doesn't really fit anyway.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>

cmd/podman-testing/create.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package main
 
 import (

cmd/podman-testing/data.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package main
 
 import (

cmd/podman-testing/layer.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package main
 
 import (

cmd/podman-testing/main.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package main
 
 import (

cmd/podman-testing/remove.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package main
 
 import (

cmd/podman-testing/store_supported.go

@@ -1,5 +1,4 @@
 //go:build linux && !remote
-// +build linux,!remote
 
 package main
 

cmd/podman-testing/store_unsupported.go

@@ -1,16 +0,0 @@
-//go:build !linux || remote
-// +build !linux remote
-
-package main
-
-import "github.com/containers/podman/v5/pkg/domain/entities"
-
-const engineMode = entities.TunnelMode
-
-func storeBefore() error {
-	return nil
-}
-
-func storeAfter() error {
-	return nil
-}

cmd/podman/containers/commit.go

@@ -9,7 +9,6 @@ import (
 	"github.com/containers/common/pkg/completion"
 	"github.com/containers/podman/v5/cmd/podman/common"
 	"github.com/containers/podman/v5/cmd/podman/registry"
-	"github.com/containers/podman/v5/pkg/api/handlers"
 	"github.com/containers/podman/v5/pkg/domain/entities"
 	"github.com/spf13/cobra"
 )
@@ -105,9 +104,6 @@ func commit(cmd *cobra.Command, args []string) error {
 	if !commitOptions.Quiet {
 		commitOptions.Writer = os.Stderr
 	}
-	if len(commitOptions.Changes) > 0 {
-		commitOptions.Changes = handlers.DecodeChanges(commitOptions.Changes)
-	}
 	if len(configFile) > 0 {
 		cfg, err := os.ReadFile(configFile)
 		if err != nil {

internal/domain/entities/engine_testing.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package entities
 
 import (

internal/domain/entities/testing.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package entities
 
 type CreateStorageLayerOptions struct {

internal/domain/infra/abi/testing.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package abi
 
 import (

internal/domain/infra/abi/testing_test.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package abi
 
 import "github.com/containers/podman/v5/internal/domain/entities"

internal/domain/infra/runtime_tunnel.go

@@ -1,25 +0,0 @@
-//go:build remote
-
-package infra
-
-import (
-	"context"
-	"fmt"
-
-	ientities "github.com/containers/podman/v5/internal/domain/entities"
-	"github.com/containers/podman/v5/internal/domain/infra/tunnel"
-	"github.com/containers/podman/v5/pkg/bindings"
-	"github.com/containers/podman/v5/pkg/domain/entities"
-)
-
-// NewTestingEngine factory provides a libpod runtime for testing-specific operations
-func NewTestingEngine(facts *entities.PodmanConfig) (ientities.TestingEngine, error) {
-	switch facts.EngineMode {
-	case entities.ABIMode:
-		return nil, fmt.Errorf("direct image runtime not supported")
-	case entities.TunnelMode:
-		ctx, err := bindings.NewConnectionWithIdentity(context.Background(), facts.URI, facts.Identity, facts.MachineMode)
-		return &tunnel.TestingEngine{ClientCtx: ctx}, err
-	}
-	return nil, fmt.Errorf("runtime mode '%v' is not supported", facts.EngineMode)
-}

internal/domain/infra/tunnel/testing.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package tunnel
 
 import (

internal/domain/infra/tunnel/testing_test.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package tunnel
 
 import "github.com/containers/podman/v5/internal/domain/entities"

pkg/api/handlers/compat/auth.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/changes.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_archive.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_attach.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_create.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_export.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_logs.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_pause.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_prune.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_restart.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_start.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_stats_freebsd.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_stats_linux.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_stop.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_top.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/containers_unpause.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/events.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/exec.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/images.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (
@@ -137,7 +139,7 @@ func CommitContainer(w http.ResponseWriter, r *http.Request) {
 	options.Author = query.Author
 	options.Pause = query.Pause
 	options.Squash = query.Squash
-	options.Changes = handlers.DecodeChanges(query.Changes)
+	options.Changes = util.DecodeChanges(query.Changes)
 	if r.Body != nil {
 		defer r.Body.Close()
 		if options.CommitOptions.OverrideConfig, err = abi.DecodeOverrideConfig(r.Body); err != nil {

pkg/api/handlers/compat/images_build.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/images_history.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/images_prune.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/images_push.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/images_remove.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/images_save.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/images_search.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/images_tag.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/info.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/networks.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/ping.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/resize.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/secrets.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/system.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/types.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/unsupported.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/version.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/compat/volumes.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package compat
 
 import (

pkg/api/handlers/decoder.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package handlers
 
 import (

pkg/api/handlers/libpod/containers.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/containers_create.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/containers_stats.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/generate.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/healthcheck.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/images.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (
@@ -499,7 +501,7 @@ func CommitContainer(w http.ResponseWriter, r *http.Request) {
 	options.Author = query.Author
 	options.Pause = query.Pause
 	options.Squash = query.Squash
-	options.Changes = handlers.DecodeChanges(query.Changes)
+	options.Changes = util.DecodeChanges(query.Changes)
 	ctr, err := runtime.LookupContainer(query.Container)
 	if err != nil {
 		utils.Error(w, http.StatusNotFound, err)

pkg/api/handlers/libpod/images_pull.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/images_push.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/info.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/kube.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/manifests.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/networks.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/play.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/pods.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/secrets.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/swagger_spec.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/system.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/libpod/volumes.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package libpod
 
 import (

pkg/api/handlers/swagger/doc.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 // Package swagger defines the payloads used by the Podman API
 //
 //   - errors.go: declares the errors used in the API. By embedding errors.ErrorModel, more meaningful

pkg/api/handlers/swagger/errors.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 //nolint:unused // these types are used to wire generated swagger to API code
 package swagger
 

pkg/api/handlers/swagger/models.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 //nolint:unused // these types are used to wire generated swagger to API code
 package swagger
 

pkg/api/handlers/swagger/responses.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 //nolint:unused // these types are used to wire generated swagger to API code
 package swagger
 

pkg/api/handlers/utils/apiutil/apiutil.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package apiutil
 
 import (

pkg/api/handlers/utils/apiutil/apiutil_test.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package apiutil
 
 import (

pkg/api/handlers/utils/containers.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package utils
 
 import (

pkg/api/handlers/utils/errors.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package utils
 
 import (

pkg/api/handlers/utils/handler.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package utils
 
 import (

pkg/api/handlers/utils/handler_test.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package utils
 
 import (

pkg/api/handlers/utils/images.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package utils
 
 import (

pkg/api/server/doc.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 // Package server supports a RESTful API for the Libpod library
 //
 // This documentation describes the Podman v2.x+ RESTful API. It consists of a Docker-compatible

pkg/api/server/handler_api.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/handler_logging.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/handler_panic.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/handler_rid.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/idle/tracker.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package idle
 
 import (

pkg/api/server/listener_api.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/register_archive.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/register_auth.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/register_containers.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/register_distribution.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/register_events.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/register_exec.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/register_generate.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/register_healthcheck.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/register_images.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (

pkg/api/server/register_info.go

@@ -1,3 +1,5 @@
+//go:build !remote
+
 package server
 
 import (