opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-07-03 09:17:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

sigproxy: ignore if container already removed

Browse Source 
If the container is already removed do not log a warning as this happens
in parallel so it is possible the container was already removed. The
flake was shown in https://github.com/containers/podman/pull/26017.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This commit is contained in:
Paul Holzinger
2025-04-30 17:59:00 +02:00
parent 9ce708774e
commit 8de2e0ec21
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/domain/infra/abi/terminal/sigproxy_commn.go
View File

@ -33,7 +33,8 @@ func ProxySignals(ctr *libpod.Container) {
} }
if err := ctr.Kill(uint(syscallSignal)); err != nil { if err := ctr.Kill(uint(syscallSignal)); err != nil {
if errors.Is(err, define.ErrCtrStateInvalid) { // If the container is no longer running/removed do not log it as error.
if errors.Is(err, define.ErrCtrStateInvalid) || errors.Is(err, define.ErrNoSuchCtr) || errors.Is(err, define.ErrCtrRemoved) {
logrus.Infof("Ceasing signal forwarding to container %s as it has stopped", ctr.ID()) logrus.Infof("Ceasing signal forwarding to container %s as it has stopped", ctr.ID())
} else { } else {
logrus.Errorf("forwarding signal %d to container %s: %v", s, ctr.ID(), err) logrus.Errorf("forwarding signal %d to container %s: %v", s, ctr.ID(), err)