opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-07-02 00:30:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use a defined constant instead of a hard-coded magic value

Browse Source 
Use specV1.AnnotationTitle instead of hard-coding its value when we go
looking for podman-machine images.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
This commit is contained in:
Nalin Dahyabhai
2024-04-05 13:31:25 -04:00
parent 349ef318a4
commit 8afa06ee89
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/machine/ocipull/source.go
View File

@ -107,9 +107,9 @@ func GetDiskArtifactReference(ctx context.Context, imgSrc types.ImageSource, opt
// podman-machine-images should have a original file name // podman-machine-images should have a original file name
// stored in the annotations under org.opencontainers.image.title // stored in the annotations under org.opencontainers.image.title
// i.e. fedora-coreos-39.20240128.2.2-qemu.x86_64.qcow2.xz // i.e. fedora-coreos-39.20240128.2.2-qemu.x86_64.qcow2.xz
originalFileName, ok := v1MannyFest.Layers[0].Annotations["org.opencontainers.image.title"] originalFileName, ok := v1MannyFest.Layers[0].Annotations[specV1.AnnotationTitle]
if !ok { if !ok {
return "", fmt.Errorf("unable to determine original artifact name: missing required annotation 'org.opencontainers.image.title'") return "", fmt.Errorf("unable to determine original artifact name: missing required annotation '%s'", specV1.AnnotationTitle)
} }
logrus.Debugf("original artifact file name: %s", originalFileName) logrus.Debugf("original artifact file name: %s", originalFileName)
return artifactDigest, err return artifactDigest, err