opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-08-06 11:32:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

image list: speed up

Browse Source 
Listing images has shown increasing performance penalties with an
increasing number of images.  Unless `--all` is specified, Podman
will filter intermediate images.  Determining intermediate images
has been done by finding (and comparing!) parent images which is
expensive.  We had to query the storage many times which turned it
into a bottleneck.

Instead, create a layer tree and assign one or more images to nodes that
match the images' top layer.  Determining the children of an image is
now exponentially faster as we already know the child images from the
layer graph and the images using the same top layer, which may also be
considered child images based on their history.

On my system with 510 images, a rootful image list drops from 6 secs
down to 0.3 secs.

Also use the tree to compute parent nodes, and to filter intermediate
images for pruning.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
This commit is contained in:
Valentin Rothberg
2020-08-04 15:55:53 +02:00
parent 1ed1e583a0
commit 8827100b98
6 changed files with 276 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
pkg/api/handlers/utils/images.go
View File

@ -102,20 +102,14 @@ func GetImages(w http.ResponseWriter, r *http.Request) ([]*image.Image, error) {
if query.All {
return images, nil
}
returnImages := []*image.Image{}
for _, img := range images {
if len(img.Names()) == 0 {
parent, err := img.IsParent(r.Context())
if err != nil {
return nil, err
}
if parent {
continue
}
}
returnImages = append(returnImages, img)
filter, err := runtime.ImageRuntime().IntermediateFilter(r.Context(), images)
if err != nil {
return nil, err
}
return returnImages, nil
images = image.FilterImages(images, []image.ResultFilter{filter})
return images, nil
}
func GetImage(r *http.Request, name string) (*image.Image, error) {