opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-25 12:20:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove TODO comment

Browse Source 
Allowing custom flags to provider has the potential to break all the
hand-crafted commands currently in use. This could become a support
nightmare.

```release-note
NONE
```

[NO NEW TESTS NEEDED]

Signed-off-by: Jhon Honce <jhonce@redhat.com>
This commit is contained in:
Jhon Honce
2022-05-26 10:21:11 -07:00
parent e3663fbd7a
commit 87ad460603
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/podman/machine/init.go
View File

@ -25,16 +25,14 @@ var (
Example: `podman machine init myvm`, Example: `podman machine init myvm`,
ValidArgsFunction: completion.AutocompleteNone, ValidArgsFunction: completion.AutocompleteNone,
} }
)
var (
initOpts = machine.InitOptions{} initOpts = machine.InitOptions{}
defaultMachineName = machine.DefaultMachineName defaultMachineName = machine.DefaultMachineName
now bool now bool
) )
// maxMachineNameSize is set to thirty to limit huge machine names primarily // maxMachineNameSize is set to thirty to limit huge machine names primarily
// because macos has a much smaller file size limit. // because macOS has a much smaller file size limit.
const maxMachineNameSize = 30 const maxMachineNameSize = 30
func init() { func init() {
@ -111,8 +109,7 @@ func init() {
flags.BoolVar(&initOpts.Rootful, rootfulFlagName, false, "Whether this machine should prefer rootful container execution") flags.BoolVar(&initOpts.Rootful, rootfulFlagName, false, "Whether this machine should prefer rootful container execution")
} }
// TODO should we allow for a users to append to the qemu cmdline? func initMachine(_ *cobra.Command, args []string) error {
func initMachine(cmd *cobra.Command, args []string) error {
var ( var (
err error err error
vm machine.VM vm machine.VM
@ -122,7 +119,7 @@ func initMachine(cmd *cobra.Command, args []string) error {
initOpts.Name = defaultMachineName initOpts.Name = defaultMachineName
if len(args) > 0 { if len(args) > 0 {
if len(args[0]) > maxMachineNameSize { if len(args[0]) > maxMachineNameSize {
return errors.New("machine name must be 30 characters or less") return errors.Errorf("machine name %q must be %d characters or less", args[0], maxMachineNameSize)
} }
initOpts.Name = args[0] initOpts.Name = args[0]
} }