From 80652cacfce4d0d02fdba61162a13057822d6d90 Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Tue, 11 Apr 2023 15:29:12 +0200 Subject: [PATCH] test/e2e: deduplicated network test This test was added twice once for CNI and netavark, just write it once there is no need to do this weird skip thing. Signed-off-by: Paul Holzinger --- test/e2e/network_test.go | 54 +--------------------------------------- 1 file changed, 1 insertion(+), 53 deletions(-) diff --git a/test/e2e/network_test.go b/test/e2e/network_test.go index 2e9cf05f90..4671fd3ccc 100644 --- a/test/e2e/network_test.go +++ b/test/e2e/network_test.go @@ -477,59 +477,7 @@ var _ = Describe("Podman network", func() { Expect(lines[1]).To(Equal(netName2)) }) - It("podman CNI network with multiple aliases", func() { - SkipIfNetavark(podmanTest) - var worked bool - netName := createNetworkName("aliasTest") - session := podmanTest.Podman([]string{"network", "create", netName}) - session.WaitWithDefaultTimeout() - defer podmanTest.removeNetwork(netName) - Expect(session).Should(Exit(0)) - - interval := 250 * time.Millisecond - for i := 0; i < 6; i++ { - n := podmanTest.Podman([]string{"network", "exists", netName}) - n.WaitWithDefaultTimeout() - worked = n.ExitCode() == 0 - if worked { - break - } - time.Sleep(interval) - interval *= 2 - } - - top := podmanTest.Podman([]string{"run", "-dt", "--name=web", "--network=" + netName, "--network-alias=web1", "--network-alias=web2", NGINX_IMAGE}) - top.WaitWithDefaultTimeout() - Expect(top).Should(Exit(0)) - interval = 250 * time.Millisecond - // Wait for the nginx service to be running - for i := 0; i < 6; i++ { - // Test curl against the container's name - c1 := podmanTest.Podman([]string{"run", "--dns-search", "dns.podman", "--network=" + netName, NGINX_IMAGE, "curl", "web"}) - c1.WaitWithDefaultTimeout() - worked = c1.ExitCode() == 0 - if worked { - break - } - time.Sleep(interval) - interval *= 2 - } - Expect(worked).To(BeTrue()) - - // Nginx is now running so no need to do a loop - // Test against the first alias - c2 := podmanTest.Podman([]string{"run", "--dns-search", "dns.podman", "--network=" + netName, NGINX_IMAGE, "curl", "web1"}) - c2.WaitWithDefaultTimeout() - Expect(c2).Should(Exit(0)) - - // Test against the second alias - c3 := podmanTest.Podman([]string{"run", "--dns-search", "dns.podman", "--network=" + netName, NGINX_IMAGE, "curl", "web2"}) - c3.WaitWithDefaultTimeout() - Expect(c3).Should(Exit(0)) - }) - - It("podman Netavark network with multiple aliases", func() { - SkipIfCNI(podmanTest) + It("podman network with multiple aliases", func() { var worked bool netName := createNetworkName("aliasTest") session := podmanTest.Podman([]string{"network", "create", netName})