opensource/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2025-06-26 21:07:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

correct go-binding key for volumes

Browse Source 
the go binding for remove container was using 'vols' for a key to remove volumes associated to the container.  the correct key should be "v" and is documented as such.

Fixes: #7128

Signed-off-by: Brent Baude <bbaude@redhat.com>
This commit is contained in:
Brent Baude
2020-08-04 13:41:44 -05:00
parent d4cf3c589d
commit 7590a415d0
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/bindings/containers/containers.go
View File

@ -98,7 +98,7 @@ func Remove(ctx context.Context, nameOrID string, force, volumes *bool) error {
params.Set("force", strconv.FormatBool(*force)) params.Set("force", strconv.FormatBool(*force))
} }
if volumes != nil { if volumes != nil {
params.Set("vols", strconv.FormatBool(*volumes)) params.Set("v", strconv.FormatBool(*volumes))
} }
response, err := conn.DoRequest(nil, http.MethodDelete, "/containers/%s", params, nil, nameOrID) response, err := conn.DoRequest(nil, http.MethodDelete, "/containers/%s", params, nil, nameOrID)
if err != nil { if err != nil {

2
test/system/160-volumes.bats
View File

@ -142,8 +142,6 @@ EOF
# Anonymous temporary volumes, and persistent autocreated named ones # Anonymous temporary volumes, and persistent autocreated named ones
@test "podman volume, implicit creation with run" { @test "podman volume, implicit creation with run" {
skip_if_remote "FIXME: pending #7128"
# No hostdir arg: create anonymous container with random name # No hostdir arg: create anonymous container with random name
rand=$(random_string) rand=$(random_string)
run_podman run -v /myvol $IMAGE sh -c "echo $rand >/myvol/myfile" run_podman run -v /myvol $IMAGE sh -c "echo $rand >/myvol/myfile"